filab/packages_apps_Messaging
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,412 Commits 1 Branch 0 Tags
ff479f4ca4e3ef080e7e3e751be1ceffc300fe79
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Taesu Lee 6800737041 Fix wrong sync message issue for pending outgoing messages am: bccecb6393 am: 6af3221619 am: cf7a8b123a 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1547734

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ifae7ac0acbe08f351b9c057a5912c3fe175ae02e
 2021-01-12 22:08:19 +00:00
Taesu Lee cf7a8b123a Fix wrong sync message issue for pending outgoing messages am: bccecb6393 am: 6af3221619 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1547734

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I21fb2baa06e6f91804ab9b8610334d87f747a67e
 2021-01-12 21:02:31 +00:00
Taesu Lee 6af3221619 Fix wrong sync message issue for pending outgoing messages am: bccecb6393 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1547734

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Id836b2cb21964189880a56c4747b1903907631b6
 2021-01-12 20:46:50 +00:00
Taesu Lee bccecb6393 Fix wrong sync message issue for pending outgoing messages 
If sync operation is occurred between ResendMessageAction and
SendMessageAction, the pending outgoing messages in local db are deleted
and new messages are added from remote db.

To fix this issue, ResendMessageAction will update RETRY_TIMESTAMP only.
And RECEIVED_TIMESTAMP and SENT_TIMESTAMP will be updated in
SendMessageAction when the message is queued.

Test: manual

Change-Id: I0ffa6f46a7094ec3dfd2954d4313b78dd57d6994
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2021-01-12 18:50:34 +09:00
Taesu Lee b84d8bddf2 Mark messages as failed if SIM is inactive am: 8c08a3f419 am: 947784d4f3 am: 5b6d2cb110 am: c4339a83a9 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1449316

Change-Id: I75c3cb226b5265f685a0aeba416edf88bc8b86ef
 2020-10-07 19:15:33 +00:00
Taesu Lee c4339a83a9 Mark messages as failed if SIM is inactive am: 8c08a3f419 am: 947784d4f3 am: 5b6d2cb110 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1449316

Change-Id: I07d62d0098cf3c1e22f3b8f8c0f5dd9d3cc400e3
 2020-10-07 18:43:09 +00:00
Taesu Lee 5b6d2cb110 Mark messages as failed if SIM is inactive am: 8c08a3f419 am: 947784d4f3 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1449316

Change-Id: I2b59d1cc26f6e021ccac3ebac5ee7dbc51261201
 2020-10-07 18:25:04 +00:00
Taesu Lee 947784d4f3 Mark messages as failed if SIM is inactive am: 8c08a3f419 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1449316

Change-Id: I287467e6768f4915706710ab0172455ec6510f8c
 2020-10-07 17:57:01 +00:00
Taesu Lee 8c08a3f419 Mark messages as failed if SIM is inactive 
If a SIM is inactive, Mark messages corresponding to the SIM as failed
instead of updating selfId as default selfId. The failed messages could
be sent through the SIM manually if the SIM is re-activated.

Test: Manual

Change-Id: I1eee7c12aaedebe8aa3e0c41b4b057758a3b17a2
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2020-10-06 12:33:21 +09:00
Taesu Lee bd2a71280d Fix creating a new conversation including own number am: 9c97af9b83 am: e7df722655 am: 71f8b60cdf am: 492f7ee2d1 am: 807d8130e0 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1427818

Change-Id: Iec2bf14cd5aaf73701166721537ca2136a8b0b68
 2020-09-16 23:54:01 +00:00
Taesu Lee 807d8130e0 Fix creating a new conversation including own number am: 9c97af9b83 am: e7df722655 am: 71f8b60cdf am: 492f7ee2d1 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1427818

Change-Id: I66c7f94ca94bf20ac47f0b6c07d61d65fe7aaea4
 2020-09-16 22:59:47 +00:00
Taesu Lee 492f7ee2d1 Fix creating a new conversation including own number am: 9c97af9b83 am: e7df722655 am: 71f8b60cdf 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1427818

Change-Id: Ie2d803c9ed06cc4f404a8b0cc05e44d6905cea73
 2020-09-16 20:41:35 +00:00
Taesu Lee 71f8b60cdf Fix creating a new conversation including own number am: 9c97af9b83 am: e7df722655 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1427818

Change-Id: Ia88e65e4206eef84961c3d7dee3cda7b0330623f
 2020-09-16 20:26:32 +00:00
Taesu Lee e7df722655 Fix creating a new conversation including own number am: 9c97af9b83 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1427818

Change-Id: I692d40a9ab2d1f262ed2ad5a12cc47a7cdc46d64
 2020-09-16 19:41:45 +00:00
Taesu Lee 9c97af9b83 Fix creating a new conversation including own number 
If a device own phone number is unknown and there is only a single
address in all TO and CC for incoming MMS, ignore the address as it is
device own phone number.

Test: Manual

Change-Id: I26de39bd3b71d3ad391372f35cfce0bd5c7b66ed
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2020-09-16 15:19:58 +09:00
Taesu Lee f2d9199bfb Fix NoSuchMethodError for getTypeInfo() 
Load an icon image for audio files from app resources instead because
ContentResolver#getTypeInfo() is for API level >= 29.
And it includes size-fit ic_photo_library_light images also.

Bug: 159987488
Test: Manual

Change-Id: Ie8f766f148a30e105e598e4b7e6b1b22bccda6ae
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2020-06-29 15:51:07 +09:00
Taesu Lee 2a2cdcb62d Remove advanced category if no preference am: 392850a825 am: 34ebed2bba am: 45cd97eabf am: 5538d47259 am: bc5055fc79 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: I660a67e21056706099c3dc83daecb9db6d30c1ed
 2020-06-26 17:53:10 +00:00
Taesu Lee bc5055fc79 Remove advanced category if no preference am: 392850a825 am: 34ebed2bba am: 45cd97eabf am: 5538d47259 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Ia4902eaf2d7b8c94c113fb662680cfe270c73b78
 2020-06-26 17:27:34 +00:00
Taesu Lee 5538d47259 Remove advanced category if no preference am: 392850a825 am: 34ebed2bba am: 45cd97eabf 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Ic6105759c8b90ffcce82c12e70e962e19b50bbd5
 2020-06-26 17:15:23 +00:00
Taesu Lee 45cd97eabf Remove advanced category if no preference am: 392850a825 am: 34ebed2bba 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: I40e97e119cfefaf90e14efad2760e9e31a46a9b8
 2020-06-26 17:00:47 +00:00
Taesu Lee 34ebed2bba Remove advanced category if no preference am: 392850a825 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Icbed01452b088198a11436aad233c281b4068067
 2020-06-26 16:48:17 +00:00
Taesu Lee 392850a825 Remove advanced category if no preference 
Test: In debug mode, turn off all the configs for advanced category

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I52ea0905b9d4f03a57b4849e5b575bc5e508dd2d
 2020-06-26 19:25:05 +09:00
Taesu Lee 8c271ffd8a Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb am: 5c393695c6 am: 43f98b38f0 am: 81c0058f19 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: Ie5027715683aa05795feb221ef4c5d3f68a9b2af
 2020-06-22 17:59:59 +00:00
Taesu Lee 81c0058f19 Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb am: 5c393695c6 am: 43f98b38f0 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: I6c9bdd5493abc298c784d1164030d0d6b63685d2
 2020-06-22 17:34:49 +00:00
Taesu Lee 43f98b38f0 Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb am: 5c393695c6 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: Ia252373a2a6109a881feee44a5d20be6e5aec464
 2020-06-22 17:21:11 +00:00
Taesu Lee 5c393695c6 Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: I2dd1a3cc46f51f2ca743674bab363c6e90f5f0ad
 2020-06-22 17:06:36 +00:00
Taesu Lee ba59a36fdb Fix app initialization issue if no permissions am: 297a6f7047 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: If592a8e5431035c8a369917f24dbdd73e28bae4d
 2020-06-22 16:53:14 +00:00
Taesu Lee 615ebb9dd6 Fix SecurityException at getActiveSubscriptionInfoList() on N and O 
Creating ConnectivityUtil instances after checking the minimum set of
permissions since SubscriptionManager#getActiveSubscriptionInfoList()
requires READ_PHONE_STATE and users can revoke the permission.
On P and beyond, the subscription list will be filtered instead when no
permission.

Bug: 159421050
Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iafc3c57060e1893a91e629b1b3e3ba9ad78967cb
 2020-06-22 19:15:39 +09:00
Taesu Lee 297a6f7047 Fix app initialization issue if no permissions 
Call onRequiredPermissionsAcquired() before calling redirect() so that
BugleApplication initialization can be done completed always even
PermissionCheckActivity#onResume() case.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I01bb681442e0b391238bc162ce139ff40d947eaf
 2020-06-22 19:14:52 +09:00
Taesu Lee 9c553cd25b Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3 am: 298adffd13 am: 4c7d42037d 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I496f82b543d519415ed93c55097a59507582e57c
 2020-06-19 18:01:02 +00:00
Taesu Lee 4c7d42037d Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3 am: 298adffd13 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: Icdc1452f8129a561a50f35e5e22b3c2fa9651ecc
 2020-06-19 17:52:58 +00:00
Taesu Lee 298adffd13 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I5433d17c76decd475b357d0ebefc83b53dc29098
 2020-06-19 17:30:36 +00:00
Taesu Lee 619f7547d3 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I7ea06fcff9be951ae5994ca1d9fc5d7d1efe648e
 2020-06-19 17:16:27 +00:00
Taesu Lee 5db150a742 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: If165c85253bfd9bdcc2c3939def095968796fe83
 2020-06-19 17:04:20 +00:00
Taesu Lee 0c7ab8c20a Remove only one Lambda Exp for JAVA 7 
Remove a Lambda Exp and replace ConcurrentHashMap#computeIfAbsent() with
containsKey() and put() so that this app can be built using JAVA 7.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I7ff8a3b5fc4673dfe05c5ecc9418d377f3ed4f2e
 2020-06-19 19:30:58 +09:00
Taesu Lee bd3b711aca Fix handling format based on API level accordingly. 
Use SmsMessage#createFromPdu(pdu, format) at least on M and replace
SmsMessage#FORMAT_3GPP2 with "3gpp2".
 - SmsMessage#createFromPdu(pdu, format) is added in API level 23.
 - SmsMessage#FORMAT_3GPP2 is added in API level 28.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Icab2c6c3c86ee8b6597881bfac6066fed60db4d2
 2020-06-19 18:34:20 +09:00
Taesu Lee a3b82b03fb Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e am: d5a77b3938 am: 148742e0ad 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Ia382ebb1118cc71d4ab90de6211c20d49487c295
 2020-06-18 18:31:10 +00:00
Taesu Lee 148742e0ad Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e am: d5a77b3938 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: I4801c9d21ff246d6de3f16842ed3caa4421dc2ca
 2020-06-18 18:10:41 +00:00
Taesu Lee d5a77b3938 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: I46cbce580c764748726666b3febe3b07f4633b5a
 2020-06-18 17:53:52 +00:00
Taesu Lee d810c8b49e Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Icc9cbfc22b10f73726ea7230c0e463d459c1830b
 2020-06-18 17:40:18 +00:00
Taesu Lee 86314ff8e6 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Id737b6239df8b85888e7832ab6f5e157be94de1f
 2020-06-18 17:27:52 +00:00
Taesu Lee dcfe928ff3 Fix creating ConnectivityUtil to work on any platform 
After this CL, ConnectivityUtil for default subId is used again on pre
N because TelephonyManager has createForSubscriptionId() for a specific
subId from N.
Nevertheless, listen() uses the default subId on PhoneStateListener
instead of the subId on the manager still even N. On O and beyond,
ConnectivityUtil works correctly on multi-sim devices.

Revert "Fix missing computeIfAbsent() method in L_MR1 and M"

This reverts commit f0ccb76d8d.

Reason for revert: Manage ConnectivityUtil instances for subIds at least
                   on N instead.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I2f08928a6798a2ce275c5c75569ad379999d274c
 2020-06-18 19:24:27 +09:00
Taesu Lee f0ccb76d8d Fix missing computeIfAbsent() method in L_MR1 and M 
Replace ConcurrentHashMap#computeIfAbsent() with containsKey() and put()
since computeIfAbsent() is added in API level 24.

Bug: 158846265
Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I3c43f0d7b1f289f0442c9359de4f099217244387
 2020-06-17 19:03:26 +09:00
Taesu Lee 9f2b2181a1 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 am: 3aae6cf088 am: cfb6bd2b00 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Iacc4eb93e2e8fa12a8f96b94efedcefc5d9b7d3f
 2020-06-16 17:13:31 +00:00
Taesu Lee cfb6bd2b00 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 am: 3aae6cf088 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I3b694db3a215a3bed07620a4340f2652da353a47
 2020-06-16 17:01:24 +00:00
Taesu Lee 3aae6cf088 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I42852de2576cff4a5582e5b05623cbf22716a9dc
 2020-06-16 16:52:42 +00:00
Taesu Lee 742b382d83 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Ied8b839de8e07d04c89be7c24aaf8ea387a663d1
 2020-06-16 16:45:35 +00:00
Taesu Lee b9dd11dd77 Remove unnecessary methods from MmsUtils am: c9e85fd21a 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I6359187593ac39b7bbd1628cab743586515f72e8
 2020-06-16 16:23:53 +00:00
Taesu Lee c9e85fd21a Remove unnecessary methods from MmsUtils 
Same methods in PhoneUtils are used everywhere instead.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia17c1f17511c53a9235af462fa0809146726e89f
 2020-06-16 11:00:42 +09:00
Taesu Lee 5adcd1bb5c Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 am: d851c2f7f0 am: f800178df7 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I54b8f73f65294d75ba73f0bc710a7a252a1b4925
 2020-06-11 19:53:07 +00:00
Taesu Lee f800178df7 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 am: d851c2f7f0 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I420e82330ac5582d165a4353d1e5b517ff7dca55
 2020-06-11 19:41:14 +00:00
Taesu Lee d851c2f7f0 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Ie80fb55d3080d7f7f1f4c4dcb49aef84d09e2ee8
 2020-06-11 19:29:09 +00:00
Taesu Lee c3e125df64 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I4310dfdbf854572427d43d87a4c31702a36a1598
 2020-06-11 19:16:35 +00:00
Taesu Lee d067695cd8 Allow call to phone numbers or voice mail numbers only am: 8b347325fa 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Iaa1761772b4e7991e009fce48e692a99ebe09150
 2020-06-11 19:05:57 +00:00
Taesu Lee 8b347325fa Allow call to phone numbers or voice mail numbers only 
It allows to call to well-formatted phone numbers or carrier specific
phone numbers starting with star sign such as *20 so that user can make
a call directly in a conversation for voice mail SMSs.

Revert "Check whether dialable only"

This reverts commit dbc43316cf.

Reason for revert: a call icon is disappeared for well-formatted phone
                   number with parentheses, dash and etc.

Test: Check the call icon in conversations for phone numbers and voice
      mail numbers.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I1b279f8a5372b00a5a0c572f9969731f1e633389
 2020-06-11 18:56:04 +09:00
Taesu Lee b578b890f7 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 am: 8a2358c4d5 am: 4209131fcc 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I8cdd684107f2d7fdc4e5be4b3ff1f3d7a78e0ad2
 2020-06-08 18:18:56 +00:00
Taesu Lee 4209131fcc Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 am: 8a2358c4d5 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I745a7b56e0acb9fcb9a1f68dd977253dc3e62f7a
 2020-06-08 18:01:21 +00:00
Taesu Lee 8a2358c4d5 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I55dfb1611ea32b9318cae568a75f89b4ba77635d
 2020-06-08 17:40:30 +00:00
Taesu Lee 2f60034413 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: Idd83c8097c70305e74bf86bf0b61df48e3115fd3
 2020-06-08 17:25:09 +00:00
Taesu Lee 638c7a6817 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: If82c2db8dc767a806360c91c55a056cddd2f06a9
 2020-06-08 17:08:29 +00:00
Taesu Lee f3ea99181b Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always 
Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES directly for each
sending messages always so that the correct config can be used for each
SIM cards in multi-sim devices.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iff80d093f43014ff2fe97caf6929aefe43911192
 2020-06-08 16:12:02 +09:00
Taesu Lee 3ec105995f Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a am: f682a11332 am: cf18b8fd96 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I2e7a2d0b9d226b901ab31d16348493b3a55eb4e5
 2020-06-05 18:28:11 +00:00
Taesu Lee cf18b8fd96 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a am: f682a11332 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I4c44fb2747710b902c45fad2ae293a1660d4ad4c
 2020-06-05 18:09:30 +00:00
Taesu Lee f682a11332 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I5a8f884cce556db540b98523e5aba69e8b6cbae1
 2020-06-05 17:57:44 +00:00
Taesu Lee 1fd2c4656a Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia4b4c5dbe19435fc34f09bafebb0641934eec389
 2020-06-05 17:45:24 +00:00
Taesu Lee 93c591bdb0 Fix ConcurrentModificationException am: 845aa217fc 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia9e1ac9906beace9db944fcbfcf7235a6c0f29ac
 2020-06-05 17:31:20 +00:00
Taesu Lee 845aa217fc Fix ConcurrentModificationException 
ConcurrentModificationException could be happened during iterating if
parts are added newly.

Test: Select several images on Gallery app and attach them to a message
via Sharing

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Idb96239ef2c05a08fc0727797b97739aa89f12a4
 2020-06-05 14:46:51 +09:00
Taesu Lee f946d02731 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 am: 5729626c46 am: 8904e4eb2e 
Change-Id: I23da91f69d0b8c1ba1234d2a9d821b4267a0a1f9
 2020-05-28 21:38:42 +00:00
Taesu Lee 8904e4eb2e Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 am: 5729626c46 
Change-Id: I556a102be2007103462a588f448fdab6375b8e5f
 2020-05-28 21:27:33 +00:00
Taesu Lee 5729626c46 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 
Change-Id: I3081b98fcb924bf4e92571fcc02662fdc2d74716
 2020-05-28 21:14:48 +00:00
Taesu Lee 1efb769573 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 
Change-Id: Ibf098b5ea21f8277a142dde46793a7b9085f624c
 2020-05-28 20:58:51 +00:00
Taesu Lee 4e646c4948 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 
Change-Id: Ie293c1c84489e4a1f20972bc056f6d2af67b79b4
 2020-05-28 20:42:10 +00:00
Taesu Lee fcf6699742 Parse recipients from RESPOND_VIA_MESSAGE correctly 
UriUtil#parseRecipientsFromSmsMmsUri() will returns a comma-separated
recipients for common use so that InsertNewMessageAction#createMessage()
can create or get a conversation correctly for RESPOND_VIA_MESSAGE.
In addition, mms/mmsto schemes are added. And it includes small cleanup
intent-filters for LaunchConversationActivity.

Test: adb shell am startservice
-a android.intent.action.RESPOND_VIA_MESSAGE -d "sms:12345678,87654321"
-e android.intent.extra.TEXT "Text"

Change-Id: I291dc765a46846982d059016d44f90873c687867
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2020-05-28 16:43:29 +09:00
Taesu Lee 6aff72ba38 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c am: 395876eb17 am: be4f0807b6 
Change-Id: Id3d820d0ef08706ff40ec8343a655bc5fa2705a5
 2020-05-25 22:03:22 +00:00
Taesu Lee be4f0807b6 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c am: 395876eb17 
Change-Id: Icaa4d5dc510c1ff34a48344634158842c1398cf7
 2020-05-25 21:51:38 +00:00
Taesu Lee 395876eb17 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c 
Change-Id: Ie4dba4cb8405e839e8927d0346d1a4c377bf0e82
 2020-05-25 21:36:43 +00:00
Taesu Lee f1f488257c Check whether dialable only am: dbc43316cf am: 45741a4489 
Change-Id: Ib9aa219781543d90c309df876ba588dbc38faf3d
 2020-05-25 21:20:14 +00:00
Taesu Lee 45741a4489 Check whether dialable only am: dbc43316cf 
Change-Id: I517a73f1dcae564e177db748361c1f508bb426a0
 2020-05-25 21:05:07 +00:00
Taesu Lee ea623cfb18 Remove dead code 
No need code to handle any retry case after downloading MMS.

Test: No behavior change

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I053f85e0260f7c4cd76d52114077d220ac0b25ba
 2020-05-25 18:30:12 +09:00
Taesu Lee 9a0a21e836 Disallow making a call to emergency numbers 
Show an error toast instead since ACTION_CALL intent cannot be used to
call emergency numbers.

Test: Make a call to an emergency number.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia42c588848b643def068dec1d73e2e917a4b8214
 2020-05-25 17:52:44 +09:00
Taesu Lee dbc43316cf Check whether dialable only 
It allows to call to any sender such as *20(Voice Mail Number for
Chile Claro).

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ifca83c5f05018de627fa38318fd4b6db20370910
 2020-05-25 15:22:26 +09:00
Taesu Lee 6bef426148 Auto re-sending MMS for all the transient failures 
All the transient failures should be treated as same even reserved
values for future purposes.
(OMA-MMS-ENC-V1_2, 7.2.37. X-Mms-Response-Status field)

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia2739baebbf156b6fadee0fee71956b044c14234
 2020-05-25 14:05:31 +09:00
Taesu Lee d624e1ac26 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1 am: 925e555dd6 am: aedb8b69e9 
Change-Id: I8cda0c42e9aa4afcd4a4e67a50e31448ab42365c
 2020-05-19 01:52:35 +00:00
Taesu Lee aedb8b69e9 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1 am: 925e555dd6 
Change-Id: I0914fe244002a0b24359280ca56f3094dc2a5b1c
 2020-05-19 01:26:23 +00:00
Taesu Lee 925e555dd6 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1 
Change-Id: I573a2677ae98dbab953bb5bef67b99d95610ff41
 2020-05-19 01:08:32 +00:00
Taesu Lee 1e144034d1 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 
Change-Id: I5604cfaa4a27fdf75cc4c092650988161b18d23c
 2020-05-19 00:52:59 +00:00
Taesu Lee 3bf899c587 Rescheduling pending messages after outside window failure am: 0ff700cea4 
Change-Id: I84881b6b958ea11fc42c2e8c6b21d0b29b8fef64
 2020-05-19 00:39:33 +00:00
Taesu Lee 0ff700cea4 Rescheduling pending messages after outside window failure 
No more rescheduling for pending messages after DownloadMmsAction is
failed caused by outside window. Any pending download messages will be
remained as the DOWNLOADING state without actual downloading operations
and sending a DEFERRED M-NotifyResp.ind even.
It will reschedule pending messages whenever sending or downloading is
failed including outside window failure case. And it also removes dup
scheduling and fix some typo.

Test: Manual

Change-Id: Ie37088347c69f25d838875830fc65ce7727fefe6
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
 2020-05-18 13:16:50 +09:00
Taesu Lee 6fc02eec9f Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a am: 2393df67e4 am: 3727f330af 
Change-Id: I77172379db7ad72a0b55f0297da14e0b58938717
 2020-05-08 18:52:05 +00:00
Taesu Lee 3727f330af Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a am: 2393df67e4 
Change-Id: I7596f66873a44213d14fcc807a788d2a90cda5b2
 2020-05-08 18:40:34 +00:00
Taesu Lee 2393df67e4 Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a 
Change-Id: Ib018f30bd8592fa61eada8ce5c81ce59b8d60de6
 2020-05-08 18:25:33 +00:00
Taesu Lee fc61c91c8a Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 
Change-Id: I7a06e4b055021fce0a34bb1d03f7ab629c46c832
 2020-05-08 18:07:30 +00:00
Taesu Lee 2cbca58166 Fix NPE on MultiConversationNotificationState am: 9635b646d8 
Change-Id: If8596050a9463200ea5244db1051a6ce4082e047
 2020-05-08 17:55:19 +00:00
Taesu Lee 9635b646d8 Fix NPE on MultiConversationNotificationState 
Use the most recent notification's state to print out log because
mContent is null in case of a notification for multiple messages in at
least 2 different conversations.
And no need sanitizePII() since this log is only for VERBOSE already.

Test: 1) adb shell setprop log.tag.MessagingAppNotif VERBOSE
      2) Receive SMS from different senders

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ie300620f0014577ca65b9a7e3a4c397a39717992
 2020-05-08 19:01:59 +09:00
Taesu Lee 11216940ba Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76 am: 9d2baa4eba am: 3466711399 am: 38e2bfd4f8 
Change-Id: Ie7b1779628d114fb161ef00fbc594a38189a3aab
 2020-05-05 03:29:39 +00:00
Taesu Lee c746cb923f Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468 am: 07c87d9e1b am: d982d11e82 am: 279939c621 
Change-Id: I7fd1f676c709e990601ddc573609076541278090
 2020-05-05 03:29:29 +00:00
Taesu Lee 7eb43a2ac4 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b am: e6c7e23828 am: 797aa42f35 am: d1c27b6956 
Change-Id: I1ef9627d33837b805fc81ed87d6fa595ea977ac7
 2020-05-05 03:29:28 +00:00
Taesu Lee 38e2bfd4f8 Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76 am: 9d2baa4eba am: 3466711399 
Change-Id: I4b9ec80d1643c18e6a1370f8bb3c65059e981e24
 2020-05-05 03:14:23 +00:00
Taesu Lee 279939c621 Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468 am: 07c87d9e1b am: d982d11e82 
Change-Id: Ia9cca8e01428c17c4e68c7a9f7bf62dc5b179c5a
 2020-05-05 03:14:13 +00:00
Taesu Lee d1c27b6956 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b am: e6c7e23828 am: 797aa42f35 
Change-Id: I73b39caa0e6fa39bf4d81740e7ef1df418d6e81a
 2020-05-05 03:14:12 +00:00