filab/packages_apps_Messaging
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix wrong sync message issue for pending outgoing messages

Browse Source 
If sync operation is occurred between ResendMessageAction and
SendMessageAction, the pending outgoing messages in local db are deleted
and new messages are added from remote db.

To fix this issue, ResendMessageAction will update RETRY_TIMESTAMP only.
And RECEIVED_TIMESTAMP and SENT_TIMESTAMP will be updated in
SendMessageAction when the message is queued.

Test: manual

Change-Id: I0ffa6f46a7094ec3dfd2954d4313b78dd57d6994
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
This commit is contained in:
Taesu Lee
2021-01-12 13:40:45 +09:00
parent 89efbab65d
commit bccecb6393
2 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/messaging/datamodel/action/ResendMessageAction.java
View File

@@ -80,8 +80,6 @@ public class ResendMessageAction extends Action implements Parcelable {
final ContentValues values = new ContentValues();
values.put(MessageColumns.STATUS, MessageData.BUGLE_STATUS_OUTGOING_YET_TO_SEND);
values.put(MessageColumns.RECEIVED_TIMESTAMP, timestamp);
values.put(MessageColumns.SENT_TIMESTAMP, timestamp);
values.put(MessageColumns.RETRY_START_TIMESTAMP, timestamp);
// Row must exist as was just loaded above (on ActionService thread)

17
src/com/android/messaging/datamodel/action/SendMessageAction.java
View File

@@ -95,13 +95,17 @@ public class SendMessageAction extends Action implements Parcelable {
private boolean queueAction(final String messageId, final Action processingAction) {
actionParameters.putString(KEY_MESSAGE_ID, messageId);
final long timestamp = System.currentTimeMillis();
final DatabaseWrapper db = DataModel.get().getDatabase();
final MessageData message = BugleDatabaseOperations.readMessage(db, messageId);
// Check message can be resent
if (message != null && message.canSendMessage()) {
final boolean isSms = (message.getProtocol() == MessageData.PROTOCOL_SMS);
final boolean isSms = message.getIsSms();
long timestamp = System.currentTimeMillis();
if (!isSms) {
// MMS expects timestamp rounded to nearest second
timestamp = 1000 * ((timestamp + 500) / 1000);
}
final ParticipantData self = BugleDatabaseOperations.getExistingParticipant(
db, message.getSelfId());
@@ -110,8 +114,13 @@ public class SendMessageAction extends Action implements Parcelable {
// Update message status
if (message.getYetToSend()) {
// Initial sending of message
message.markMessageSending(timestamp);
if (message.getReceivedTimeStamp() == message.getRetryStartTimestamp()) {
// Initial sending of message
message.markMessageSending(timestamp);
} else {
// Manual resend of message
message.markMessageManualResend(timestamp);
}
} else {
// Automatic resend of message
message.markMessageResending(timestamp);