Commit Graph

905 Commits

Author SHA1 Message Date
Treehugger Robot
f5a5b979cb Merge "Fix handling format based on API level accordingly." am: d626bcaf0c am: ea97b36d27 am: f33a0d0823 am: 454d3fe0c6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: If9dae71fdd1cc5240a3ab0c0880f23aa299f922c
2020-06-19 17:53:31 +00:00
Taesu Lee
4c7d42037d Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3 am: 298adffd13
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: Icdc1452f8129a561a50f35e5e22b3c2fa9651ecc
2020-06-19 17:52:58 +00:00
Treehugger Robot
454d3fe0c6 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c am: ea97b36d27 am: f33a0d0823
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: I03c2befd38b5e2d998b77d2e0a642278b01e0d05
2020-06-19 17:30:45 +00:00
Taesu Lee
298adffd13 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I5433d17c76decd475b357d0ebefc83b53dc29098
2020-06-19 17:30:36 +00:00
Treehugger Robot
f33a0d0823 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c am: ea97b36d27
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: Ibd799529f6cef95614f2bef54ad8a9f59e7df125
2020-06-19 17:16:39 +00:00
Taesu Lee
619f7547d3 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I7ea06fcff9be951ae5994ca1d9fc5d7d1efe648e
2020-06-19 17:16:27 +00:00
Treehugger Robot
ea97b36d27 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: I71a236a34be90808809c85bbe062e6452fb06afa
2020-06-19 17:04:32 +00:00
Taesu Lee
5db150a742 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: If165c85253bfd9bdcc2c3939def095968796fe83
2020-06-19 17:04:20 +00:00
Treehugger Robot
d626bcaf0c Merge "Fix handling format based on API level accordingly." 2020-06-19 16:55:25 +00:00
Taesu Lee
0c7ab8c20a Remove only one Lambda Exp for JAVA 7
Remove a Lambda Exp and replace ConcurrentHashMap#computeIfAbsent() with
containsKey() and put() so that this app can be built using JAVA 7.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I7ff8a3b5fc4673dfe05c5ecc9418d377f3ed4f2e
2020-06-19 19:30:58 +09:00
Taesu Lee
bd3b711aca Fix handling format based on API level accordingly.
Use SmsMessage#createFromPdu(pdu, format) at least on M and replace
SmsMessage#FORMAT_3GPP2 with "3gpp2".
 - SmsMessage#createFromPdu(pdu, format) is added in API level 23.
 - SmsMessage#FORMAT_3GPP2 is added in API level 28.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Icab2c6c3c86ee8b6597881bfac6066fed60db4d2
2020-06-19 18:34:20 +09:00
Taesu Lee
148742e0ad Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e am: d5a77b3938
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: I4801c9d21ff246d6de3f16842ed3caa4421dc2ca
2020-06-18 18:10:41 +00:00
Taesu Lee
d5a77b3938 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: I46cbce580c764748726666b3febe3b07f4633b5a
2020-06-18 17:53:52 +00:00
Taesu Lee
d810c8b49e Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Icc9cbfc22b10f73726ea7230c0e463d459c1830b
2020-06-18 17:40:18 +00:00
Taesu Lee
86314ff8e6 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Id737b6239df8b85888e7832ab6f5e157be94de1f
2020-06-18 17:27:52 +00:00
Taesu Lee
dcfe928ff3 Fix creating ConnectivityUtil to work on any platform
After this CL, ConnectivityUtil for default subId is used again on pre
N because TelephonyManager has createForSubscriptionId() for a specific
subId from N.
Nevertheless, listen() uses the default subId on PhoneStateListener
instead of the subId on the manager still even N. On O and beyond,
ConnectivityUtil works correctly on multi-sim devices.

Revert "Fix missing computeIfAbsent() method in L_MR1 and M"

This reverts commit f0ccb76d8d.

Reason for revert: Manage ConnectivityUtil instances for subIds at least
                   on N instead.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I2f08928a6798a2ce275c5c75569ad379999d274c
2020-06-18 19:24:27 +09:00
Treehugger Robot
bac9c313a7 Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f am: db44cbe6db
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I88ec3dce9df8ebcdae903a43bfd2b8f49059ceb7
2020-06-17 17:12:06 +00:00
Treehugger Robot
db44cbe6db Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I6fade445937470598e0b09f1ae73e8e535530684
2020-06-17 16:53:08 +00:00
Treehugger Robot
69cd91a75f Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: Iaccb9a0bfe078bb3712c875e30877bd2e0bdf1d2
2020-06-17 16:35:40 +00:00
Treehugger Robot
feaad2df13 Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I4bdfca1d8b537b3940eec4ecf1a166b78589b2db
2020-06-17 16:22:59 +00:00
Treehugger Robot
db1ebc265c Merge "Fix missing computeIfAbsent() method in L_MR1 and M" 2020-06-17 16:15:32 +00:00
Taesu Lee
f0ccb76d8d Fix missing computeIfAbsent() method in L_MR1 and M
Replace ConcurrentHashMap#computeIfAbsent() with containsKey() and put()
since computeIfAbsent() is added in API level 24.

Bug: 158846265
Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I3c43f0d7b1f289f0442c9359de4f099217244387
2020-06-17 19:03:26 +09:00
Taesu Lee
cfb6bd2b00 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 am: 3aae6cf088
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I3b694db3a215a3bed07620a4340f2652da353a47
2020-06-16 17:01:24 +00:00
Taesu Lee
3aae6cf088 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I42852de2576cff4a5582e5b05623cbf22716a9dc
2020-06-16 16:52:42 +00:00
Taesu Lee
742b382d83 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Ied8b839de8e07d04c89be7c24aaf8ea387a663d1
2020-06-16 16:45:35 +00:00
Taesu Lee
b9dd11dd77 Remove unnecessary methods from MmsUtils am: c9e85fd21a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I6359187593ac39b7bbd1628cab743586515f72e8
2020-06-16 16:23:53 +00:00
Taesu Lee
c9e85fd21a Remove unnecessary methods from MmsUtils
Same methods in PhoneUtils are used everywhere instead.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia17c1f17511c53a9235af462fa0809146726e89f
2020-06-16 11:00:42 +09:00
Taesu Lee
f800178df7 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 am: d851c2f7f0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I420e82330ac5582d165a4353d1e5b517ff7dca55
2020-06-11 19:41:14 +00:00
Taesu Lee
d851c2f7f0 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Ie80fb55d3080d7f7f1f4c4dcb49aef84d09e2ee8
2020-06-11 19:29:09 +00:00
Taesu Lee
c3e125df64 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I4310dfdbf854572427d43d87a4c31702a36a1598
2020-06-11 19:16:35 +00:00
Taesu Lee
d067695cd8 Allow call to phone numbers or voice mail numbers only am: 8b347325fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Iaa1761772b4e7991e009fce48e692a99ebe09150
2020-06-11 19:05:57 +00:00
Taesu Lee
8b347325fa Allow call to phone numbers or voice mail numbers only
It allows to call to well-formatted phone numbers or carrier specific
phone numbers starting with star sign such as *20 so that user can make
a call directly in a conversation for voice mail SMSs.

Revert "Check whether dialable only"

This reverts commit dbc43316cf.

Reason for revert: a call icon is disappeared for well-formatted phone
                   number with parentheses, dash and etc.

Test: Check the call icon in conversations for phone numbers and voice
      mail numbers.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I1b279f8a5372b00a5a0c572f9969731f1e633389
2020-06-11 18:56:04 +09:00
Taesu Lee
4209131fcc Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 am: 8a2358c4d5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I745a7b56e0acb9fcb9a1f68dd977253dc3e62f7a
2020-06-08 18:01:21 +00:00
Taesu Lee
8a2358c4d5 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I55dfb1611ea32b9318cae568a75f89b4ba77635d
2020-06-08 17:40:30 +00:00
Taesu Lee
2f60034413 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: Idd83c8097c70305e74bf86bf0b61df48e3115fd3
2020-06-08 17:25:09 +00:00
Taesu Lee
638c7a6817 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: If82c2db8dc767a806360c91c55a056cddd2f06a9
2020-06-08 17:08:29 +00:00
Xin Li
13a6b68aa8 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours am: 8f571212fa -s ours am: 8cb54ae1f1 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I0bb8e5c145c4cac7fc72384bec31df618cd2622e
2020-06-08 16:42:09 +00:00
Xin Li
8cb54ae1f1 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours am: 8f571212fa -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I03cc090b70a60c424fe148aa3d64e3e30b345f78
2020-06-08 16:29:26 +00:00
Xin Li
8f571212fa [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I7119b174b8fa106506e689315e0ccbc71551f266
2020-06-08 16:08:08 +00:00
Xin Li
fffdde5087 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I1c87c70a6e4df7803ca0b8e310c7221fe35b1fbc
2020-06-08 15:56:53 +00:00
Taesu Lee
f3ea99181b Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always
Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES directly for each
sending messages always so that the correct config can be used for each
SIM cards in multi-sim devices.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iff80d093f43014ff2fe97caf6929aefe43911192
2020-06-08 16:12:02 +09:00
Xin Li
c66d3e6e32 Merge "Merge QQ3A.200605.002 into master" 2020-06-06 01:41:24 +00:00
Taesu Lee
cf18b8fd96 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a am: f682a11332
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I4c44fb2747710b902c45fad2ae293a1660d4ad4c
2020-06-05 18:09:30 +00:00
Taesu Lee
f682a11332 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I5a8f884cce556db540b98523e5aba69e8b6cbae1
2020-06-05 17:57:44 +00:00
Taesu Lee
1fd2c4656a Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia4b4c5dbe19435fc34f09bafebb0641934eec389
2020-06-05 17:45:24 +00:00
Taesu Lee
93c591bdb0 Fix ConcurrentModificationException am: 845aa217fc
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia9e1ac9906beace9db944fcbfcf7235a6c0f29ac
2020-06-05 17:31:20 +00:00
Taesu Lee
845aa217fc Fix ConcurrentModificationException
ConcurrentModificationException could be happened during iterating if
parts are added newly.

Test: Select several images on Gallery app and attach them to a message
via Sharing

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Idb96239ef2c05a08fc0727797b97739aa89f12a4
2020-06-05 14:46:51 +09:00
Xin Li
0580b4ade0 Merge QQ3A.200605.002 into master
Bug: 158095402
Merged-In: Ie293c1c84489e4a1f20972bc056f6d2af67b79b4
Change-Id: If9e62cf4c65cd4d4e029989f23b136c8f5efc7ae
2020-06-03 10:45:08 -07:00
Taesu Lee
8904e4eb2e Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 am: 5729626c46
Change-Id: I556a102be2007103462a588f448fdab6375b8e5f
2020-05-28 21:27:33 +00:00
Taesu Lee
5729626c46 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573
Change-Id: I3081b98fcb924bf4e92571fcc02662fdc2d74716
2020-05-28 21:14:48 +00:00