Commit Graph

1437 Commits

Author SHA1 Message Date
Michael W
f0b25f0760 Messaging: Remove unused resources
Change-Id: Id3e69fae5773ac49f16b34d428218c3ce12cbe4b
2025-05-18 09:18:48 +00:00
Michael W
c4bbba9441 Messaging: We don't need to check for verbose logging everywhere
We can just do this in the actual method

Change-Id: I80e89b0ab97926749851628b1bd34e8cd9dc82f2
2025-05-18 09:18:48 +00:00
Michael W
8613b6bcc8 Messaging: Fix wrong super() call
Change-Id: Ide21f259ff1e3b0e54811f14a5ce831c94a0da8f
2025-05-18 09:18:48 +00:00
Michael W
9fd4fa6bb9 Messaging: Explicitly specify Locale where needed
Change-Id: I636e9cceed0e73bcf957ebbda5e239982e681fd7
2025-05-18 09:18:48 +00:00
Michael W
37e5757779 Messaging: Extend AppCompatImageView instead of ImageView
Follow AS recommendation

Change-Id: Id3577cce05e73593183ea33d93c97858f9977a17
2025-05-18 09:18:48 +00:00
Michael W
7acbc6a9ca Messaging: No need to access private color members
These are public and thus we don't need "@*"

Change-Id: Iaddafed125c14e21750871c7a07abd1c4c03aee4
2025-05-18 09:18:48 +00:00
Michael W
37ac798c53 Messaging: Remove VisibleForAnimation
It's meant for reflection, but we don't care about that

Change-Id: Id2310a04fb90f39cb9b52fcb183073504b64bcba
2025-05-18 09:18:48 +00:00
LineageOS Infra
8d8c36708a Automatic translation import
Change-Id: Ib6f00a18f614b5fac8e31cf24f456f031251037a
2025-05-15 12:56:02 +00:00
LineageOS Infra
7120148897 Automatic translation import
Change-Id: Ie633b3f57231e2eb6d13101c5316099994aa81fd
2025-05-01 16:33:24 +00:00
LineageOS Infra
b3f84ba453 Automatic translation import
Change-Id: I7b72f43ef1d430cb4aff5e8fb1fae81581532032
2025-04-15 13:55:29 +00:00
LineageOS Infra
0c2fc16c8b Automatic translation import
Change-Id: Ieef595ad3118084c77d6dc09dc5b4dc78fd450bc
2025-04-07 16:25:32 +00:00
Michael W
3c107a2161 Messaging: Migrate attachments to MediaStore
* Saving them doesn't work otherwise
* We don't have to care about MediaScanner and DownloadManager
  anymore that way, either

Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/8573
Change-Id: I7a3b1dc6916feff4849bdfa2b8937460c32bc5a2
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
(cherry picked from commit 93bd39838d4a395dd710796b0e71ada1ec1f5ff2)
2025-04-04 16:33:58 +00:00
Tommy Webb
906ee2fb94 fixup! Messaging: Fix javadoc
Change-Id: Ic91c78f4e2b31e0764930cfd7ed7d376e9ba3851
2025-03-30 18:25:17 +02:00
Tommy Webb
8796975d4a Messaging: Messages are highly important
Set IMPORTANCE_HIGH so that message notifications will pop on screen
by default.

Issue: calyxos#2984
Change-Id: I6d6d823310bc0ad5f06a47df69446ebf502894dd
2025-03-30 18:25:17 +02:00
Michael W
a39f270385 Messaging: Fix wrong thumb tint
forceDarkAllowed once again messes with proper styling

Change-Id: I1d59477ae4dbd7d081787f90eab633027b575bf3
2025-03-11 22:41:22 +01:00
Thomas Turner
a8f89a1bb6 Messaging: Resolve missing symbol
packages/apps/Messaging/src/com/android/messaging/ui/ContactIconView.java:60: error: cannot find symbol
        final int iconSizeId = a.getInt(R.styleable.ContactIconView_iconSize, 0);
                                                   ^
symbol:   variable ContactIconView_iconSize
location: class styleable

Change-Id: I83b0d869a02971c43eb1aa8b80d418832900471c
2025-03-11 20:07:48 +00:00
Michael W
37f7aaea87 Messaging: Fix wrong enum value
* Apparently in QPR2, Material Design specifies iconSize which is set
  as a dimension (18dp) and overwrites ours which is an enum
* Fix it by choosing a unique name for the styleable

Change-Id: I0e9f93dc5bf8d450ea987f3b1fde9641827f2f99
2025-03-06 20:42:27 +01:00
Michael W
53eb598b63 Messaging: Good news: we can tint the status bar properly!
* 80% opacity is not what we want anymore
* The status bar in the conversation list is also supposed to be
  tinted properly - so why not do it?

Change-Id: I03c05595cd7f5a3f8f7dea120e14f3f3e0fff0b5
2025-03-04 18:52:05 +01:00
Michael W
b0f59f9515 Messaging: Round AddContactsConfirmationDialog
Change-Id: Ib169d51e860c344182eeeb422b67f1d0d04c3887
2025-03-04 18:52:05 +01:00
Michael W
162c78fe1a Messaging: Replace fragment with FragmentContainerView
* Following recommendation of AS
* Also add the missing newlines at the end - they should be there and a
  separate change doesn't make sense

Change-Id: I90ce1574910275458f51a151c8dcd6da49433504
2025-03-04 18:52:05 +01:00
Michael W
4009b68386 Messaging: Heavily reduce the exif interface
* The only thing we need is reading one Tag, which the androidx
  implementation can do just fine.
* Apart from that there is so much unused code there...

Change-Id: I248a9e5450f1823e3eca589b8e17610940b26d01
2025-03-04 18:52:05 +01:00
Michael W
b2f5e3190e Messaging: Further code improvements
* Remove redundant casts
* getParcelable(ArrayList|Exra) without class argument is deprecated
* ViewPager.setOnPageChangeListener -> addOnPageChangeListener
* RecyclerView.setOnScrollListener -> addOnScrollListener
* Remove unused initializations
* Remove unused code

Change-Id: I21beb6c90c675a4f2cfd7e3d5ebbd18b745f5911
2025-03-04 18:52:05 +01:00
Michael W
47f5533a73 Messaging: Remove duplicate code
* mmslib contains basically the same code as android.support.v7.mms.pdu
  does, so align them code-wise and remove the mmslib duplicates
* Since mmslib contains a few usages that are now not accessible
  anymore, make the classes or methods public where it complains

Change-Id: I10b8716c0e45079e4795fda4489dc1a9535026f3
2025-03-04 18:52:05 +01:00
Michael W
f83b05ea0a Messages: Replace (Safe)AsyncTask
* AsyncTask is deprecated
* Executors and Handlers can achieve the same thing and
  are not deprecated

Change-Id: I5271bb73b848ce885eeaf5632c1da27853c56c4a
2025-03-04 18:52:05 +01:00
LineageOS Infra
94c0b8734b Automatic translation import
Change-Id: Ic10cf8ae6574bba350e8d12b0e217501e81cdc14
2025-03-01 17:50:25 +00:00
LineageOS Infra
ff479f4ca4 Automatic translation import
Change-Id: Iee2fccd125915894e7891247a681042d9c7556b2
2025-02-15 15:47:26 +00:00
LineageOS Infra
ee1c105fc1 Automatic translation import
Change-Id: Ie67d6cb6fda6a1c232a8bbd30cf58e25697e01db
2025-02-01 14:28:41 +00:00
Michael W
3b720fb586 Messaging: Move "Start chat" string to cm_strings.xml
* We don't have strings.xml in the translation pipe yet so move it to
  our own strings instead
* Add an explainer comment as well

Change-Id: I392837e194c7c5d5b4b44d5cbba2ef2f521857ed
2025-01-20 21:56:38 +01:00
LuK1337
28b9c1d2cd Messaging: Make SMS delivered and MMS sent intents mutable
Fixes MMS send status and SMS delivery reports.

Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/8074
Change-Id: I55b98619ed2d477dcc232ebdaa23b5390b7570b2
2025-01-19 17:58:59 +01:00
LineageOS Infra
c3f90af163 Automatic translation import
Change-Id: Iae84ceffae7e3b10f58ad14dc7d2730783fd8bb3
2025-01-15 20:54:54 +00:00
Michael W
278c7e93af Messaging: Hide new chat button when forwarding messages
Change-Id: I511c9745c02bc7918bb38647bd6fb79332cfe523
2025-01-01 18:56:09 +01:00
Michael W
66d57e98a3 Messaging: Handle geo uri scheme
Change-Id: I19f1039d18441cb2bd013577c41e279327f806e6
2025-01-01 18:56:09 +01:00
Michael W
7f639e3652 Messaging: Use MaterialComponents everywhere instead of AppCompat
* This is the proper thing to do
* Also fixes crash when forwarding a message

Change-Id: Ib3f34477cc9b76b1979f9e6f2f39e0f9222c16ee
2025-01-01 13:12:32 +01:00
Michael W
b50c51d38f Messaging: Remove forgotten MmsVideoRecorder
Usages removed when removing the own camera handling in commit 7f464b4

Change-Id: I7904a5079e733331c9cfc780ff21bdda8bdb9455
2024-12-26 23:54:02 +01:00
Michael W
6cdd458b69 Messaging: Tint recipient field properly
We need to tint the underline ourselves, reyling on forceDarkAllowed
does nothing here

Change-Id: I2c390a76df5aef6e16512295521d073dbe25d5fc
2024-12-26 17:43:06 +01:00
Michael W
8ae38097b0 Messaging: Style ViewPagerTabStrip's underline properly
White will be black on dark theme -> we want white there as well

Change-Id: I7ca3b3b39ea6acc1069878bb2df98ccb269fb7dc
2024-12-26 17:31:30 +01:00
Michael W
edb268697c Messaging: Get rid of storage permissions
Since these have no effect on sdk 33 and up and everything works without
them we can get rid of those

Change-Id: I0482d8b8772dc2c64bb1930fbc6ba4852f4b4c61
2024-12-26 16:13:52 +01:00
Michael W
161c3e9fd9 Messaging: Remove VisibleForTesting
Since we removed all tests, no need to keep those flags around either

Change-Id: Icaf71832c459cecbcbddc75f552c60e48ae95189
2024-12-26 15:54:38 +01:00
Michael W
bbf90339d2 Messaging: Style the subject line properly
It needs it's own dark-theme color and a bigger border radius

Change-Id: I4f8e3dfec07653332106b8535c7431402833f159
2024-12-26 15:54:38 +01:00
Michael W
e11745afd4 Messaging: Style the attachment choosers properly
On light background they stand out lighter, but on dark they just blend
in - we can reuse the attachment background to fix that!

Change-Id: I0e0f09d0cd305ce1bc8aa07c3a20b79993d40e60
2024-12-26 15:54:38 +01:00
Michael W
3788b9d318 Messaging: Style the attachments properly
* With dark theme, they suddenly don't stand out from the background
  anymore
* Give them more rounding but not as much as the chat bubbles

Change-Id: I32c1036bda348e0c58e1cb37edbe9c7fc72309e7
2024-12-26 15:54:37 +01:00
Michael W
6e9a803f1c Messaging: Handle default SMS app setting properly
* We don't need two settings basically doing the same
* Handling the change needs to happen via RoleIntent, not
  ACTION_CHANGE_DEFAULT
* Our own name sometimes can't be retrieved from package manager (?) -
  just use it from strings

Change-Id: I28abc52329f00b33a316533f12a54a517cba3514
2024-12-26 15:54:37 +01:00
Michael W
241b4cf833 Messaging: Style even more dialogs properly
Somehow some dialogs use the theme but some need the style set manually

Change-Id: I386a0e43c10d328088066961b75a162bf2c351c1
2024-12-26 15:54:37 +01:00
Michael W
0aa08c0c3b Messaging: Finish after no more contacts are blocked
The view doesn't have a "no items available" element and it doesn't
make sense to have one since the menu item is only visible once a contact
is blocked - so after removing the last blocked contact, simply return
back to the conversation list

Change-Id: I3372e26361f6919502cac6fd27ae849d559a4c05
2024-12-26 15:54:37 +01:00
Michael W
e5eb059fbd Messaging: Rename in german
Messaging is not translated "SMS/MMS", use the proper word "Nachrichten"

Change-Id: I7b5a42598e4eca1162a806d9634fa7cb793f62da
2024-12-26 15:54:37 +01:00
Michael W
68a3707173 Messaging: Get rid of deprecated PhoneStateListener
TelephonyCallback is the new thing to use

Change-Id: I3c44210bfc02814af5d4110f507b94d0f0e8a4a0
2024-12-26 15:54:37 +01:00
Michael W
590243f8a8 Messaging: ContactMediaChooser: Remove permission requesting
We never reach this state when we remove the permission, so it makes
no sense to have code for it

Change-Id: I97f2f5d438148234ea1887462ab65735721da2f8
2024-12-26 15:54:37 +01:00
Michael W
c73fdc5064 Messaging: Replace permission requests with launchers
Change-Id: I0d12fd05fb0abaeb9bd64c8c77e0e776d5459e4d
2024-12-26 15:54:37 +01:00
Michael W
7f464b401c Messaging: Replace own camera handling with pickers
We do not need to handle camera on our own - there are apps out there
that are made for that!

Change-Id: Ifeb70e46b17bff5eb8d85c8775589efac4f2c284
2024-12-26 15:54:37 +01:00
Michael W
6cc0e38bb5 Messaging: Get rid of onActivityResult()
We are supposed to use ActivityResultLaunchers, so do it that way

Change-Id: I070ec485097c927877b3e0eb4699addc9b9df873
2024-12-26 15:54:37 +01:00