Commit Graph
6 Commits
Author SHA1 Message Date
Christoffer Adamsen 49c3d392ad Do not keep runtime invisible annotations in proguard.flags am: b0f8c82e37 am: 817de4cf62
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/3455602

Change-Id: I874a545cfde2310b4714879d1d001c3c4f47737d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-30 11:13:31 -08:00
Christoffer Adamsen 817de4cf62 Do not keep runtime invisible annotations in proguard.flags am: b0f8c82e37
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/3455602

Change-Id: I5c7bcb5fbf8a125fa2993f1da79c6e2ae50ba623
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-30 10:49:58 -08:00
Christoffer Adamsen b0f8c82e37 Do not keep runtime invisible annotations in proguard.flags
This updates the corresponding Android.bp file to keep the runtime invisible annotations, meaning this should be a no-op.

When RELEASE_R8_ONLY_RUNTIME_VISIBLE_ANNOTATIONS is enabled, keep_runtime_invisible_annotations will become a no-op, which should lead to all runtime invisible annotations being stripped from this build.

Bug: 387958004
Change-Id: Ib0090cd30d44630a1b0a1d1f0605edb7fef8c5cf
Test: existing
2025-01-17 04:34:59 -08:00
Christoffer Adamsen 3e8c4c36c6 Explicitly keep default constructor in rules without members am: 96af708145 am: e891b3615d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/3438699

Change-Id: I0d9ba3367e893f5299436eb3c12ad4e86f96cc78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-09 05:30:12 -08:00
Christoffer Adamsen e891b3615d Explicitly keep default constructor in rules without members am: 96af708145
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/3438699

Change-Id: Ic7a716a9384ebc40499b03980fe3317ad6e741c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-09 05:04:04 -08:00
Christoffer Adamsen 96af708145 Explicitly keep default constructor in rules without members
R8 implicitly keeps the default constructor when no member rules are specified. Future versions of R8 will require apps to explicitly keep the default constructors that are required for the build to work.

This conservatively changes all keep rules that currently keep the default constructor to explicitly keep the default constructor.

Future work will attempt to tighten up the rules that do not require the default constructor to be kept.

Bug: 373579455
Test: existing
Change-Id: I46dc4b01c0ee38a7033d8f16419dac00fe414fb1
2025-01-08 00:04:06 -08:00