Commit Graph

852 Commits

Author SHA1 Message Date
Treehugger Robot
7b39fd25c8 Merge "Disallow making a call to emergency numbers" am: ab856cb957 am: 6e1c1395cb am: d7098efcd1 am: 7a7734c16d
Change-Id: Ida066c7282aec89bbffc89d0c36be93a69d3e4e6
2020-05-25 21:51:59 +00:00
Treehugger Robot
e94887e20e Merge "Auto re-sending MMS for all the transient failures" am: 0e0bf43d46 am: c38bc2ec1b am: e15fdc0502 am: a4e196219c
Change-Id: I95eb0f877adb5f643b669e415659219158f75010
2020-05-25 21:51:53 +00:00
Treehugger Robot
91a86f1624 Merge "Remove dead code" am: 6287290cea am: 653f908e22 am: 13d6b8a605 am: 7543ded553
Change-Id: I9c0666ed72899bb5138d51bcd4f6a43efe563f0a
2020-05-25 21:51:48 +00:00
Taesu Lee
be4f0807b6 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c am: 395876eb17
Change-Id: Icaa4d5dc510c1ff34a48344634158842c1398cf7
2020-05-25 21:51:38 +00:00
Treehugger Robot
7a7734c16d Merge "Disallow making a call to emergency numbers" am: ab856cb957 am: 6e1c1395cb am: d7098efcd1
Change-Id: I6e16540cd48488d468656aa15f367205a6948997
2020-05-25 21:37:07 +00:00
Treehugger Robot
a4e196219c Merge "Auto re-sending MMS for all the transient failures" am: 0e0bf43d46 am: c38bc2ec1b am: e15fdc0502
Change-Id: Id92c98813b2ee39942acf1e81930f59648589776
2020-05-25 21:37:01 +00:00
Treehugger Robot
7543ded553 Merge "Remove dead code" am: 6287290cea am: 653f908e22 am: 13d6b8a605
Change-Id: I6695b7ab982d019d5ceeaee29e639be842d5b78f
2020-05-25 21:36:55 +00:00
Taesu Lee
395876eb17 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c
Change-Id: Ie4dba4cb8405e839e8927d0346d1a4c377bf0e82
2020-05-25 21:36:43 +00:00
Treehugger Robot
d7098efcd1 Merge "Disallow making a call to emergency numbers" am: ab856cb957 am: 6e1c1395cb
Change-Id: I17ef3d31ea8237afbf32146290435a32ce509d6e
2020-05-25 21:20:33 +00:00
Treehugger Robot
e15fdc0502 Merge "Auto re-sending MMS for all the transient failures" am: 0e0bf43d46 am: c38bc2ec1b
Change-Id: I9df0df1010295ce8dd485c4c7ed03950a84e7ff7
2020-05-25 21:20:26 +00:00
Treehugger Robot
13d6b8a605 Merge "Remove dead code" am: 6287290cea am: 653f908e22
Change-Id: I17d4112059cb571e509917de52646b98cd48e2e3
2020-05-25 21:20:20 +00:00
Taesu Lee
f1f488257c Check whether dialable only am: dbc43316cf am: 45741a4489
Change-Id: Ib9aa219781543d90c309df876ba588dbc38faf3d
2020-05-25 21:20:14 +00:00
Treehugger Robot
6e1c1395cb Merge "Disallow making a call to emergency numbers" am: ab856cb957
Change-Id: Ic46575c128f0c2916296d5a31ef81561d5ed8aa1
2020-05-25 21:05:29 +00:00
Treehugger Robot
c38bc2ec1b Merge "Auto re-sending MMS for all the transient failures" am: 0e0bf43d46
Change-Id: Ic2464c3b3adc080fa38f0d19bd0aa41866ba552c
2020-05-25 21:05:22 +00:00
Treehugger Robot
653f908e22 Merge "Remove dead code" am: 6287290cea
Change-Id: I4a4415673b4be5bd8960b0b1cecc00c9a54aa87a
2020-05-25 21:05:15 +00:00
Taesu Lee
45741a4489 Check whether dialable only am: dbc43316cf
Change-Id: I517a73f1dcae564e177db748361c1f508bb426a0
2020-05-25 21:05:07 +00:00
Treehugger Robot
ab856cb957 Merge "Disallow making a call to emergency numbers" 2020-05-25 20:52:01 +00:00
Treehugger Robot
0e0bf43d46 Merge "Auto re-sending MMS for all the transient failures" 2020-05-25 20:51:40 +00:00
Treehugger Robot
6287290cea Merge "Remove dead code" 2020-05-25 20:51:30 +00:00
Taesu Lee
ea623cfb18 Remove dead code
No need code to handle any retry case after downloading MMS.

Test: No behavior change

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I053f85e0260f7c4cd76d52114077d220ac0b25ba
2020-05-25 18:30:12 +09:00
Taesu Lee
9a0a21e836 Disallow making a call to emergency numbers
Show an error toast instead since ACTION_CALL intent cannot be used to
call emergency numbers.

Test: Make a call to an emergency number.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia42c588848b643def068dec1d73e2e917a4b8214
2020-05-25 17:52:44 +09:00
Taesu Lee
dbc43316cf Check whether dialable only
It allows to call to any sender such as *20(Voice Mail Number for
Chile Claro).

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ifca83c5f05018de627fa38318fd4b6db20370910
2020-05-25 15:22:26 +09:00
Taesu Lee
6bef426148 Auto re-sending MMS for all the transient failures
All the transient failures should be treated as same even reserved
values for future purposes.
(OMA-MMS-ENC-V1_2, 7.2.37. X-Mms-Response-Status field)

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia2739baebbf156b6fadee0fee71956b044c14234
2020-05-25 14:05:31 +09:00
Raman Tenneti
37b42eee20 Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb am: c67142cead am: 70a92bc8ff am: 167852a942
Change-Id: I100c831c11709464335b9b28979959ec4900dc7f
2020-05-21 00:46:15 +00:00
Raman Tenneti
167852a942 Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb am: c67142cead am: 70a92bc8ff
Change-Id: I6bc8da07bae126270d2cf66fda847a473bd4395d
2020-05-21 00:35:32 +00:00
Raman Tenneti
70a92bc8ff Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb am: c67142cead
Change-Id: If5c7e30643ba6ce636acf98208e331a95f7a5669
2020-05-21 00:09:59 +00:00
Raman Tenneti
c67142cead Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb
Change-Id: I631710ec3c472378ada25902c2c194dbf344fb24
2020-05-20 23:50:53 +00:00
Treehugger Robot
70498ea303 Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933 am: 54f00b323c am: 09441e4649 am: cc45cb0c0f
Change-Id: I9e0f5bb1f56094f26cd7f5e986bc998f2be46781
2020-05-20 20:04:07 +00:00
Raman Tenneti
eb1e0417eb Revert "Messaging: Add "Mark as read" quick action for message notifications"
This reverts commit f19e916a0d.

Reason for revert: Reverting per Taesu Lee's comments, because it doesn't work and has issues.

Change-Id: I778362b628f4c3ae076dd943e77dee415984fba0
2020-05-20 19:47:44 +00:00
Treehugger Robot
cc45cb0c0f Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933 am: 54f00b323c am: 09441e4649
Change-Id: If3660be7889827eaff4e2234d9a4c6a73ad4bc27
2020-05-20 19:45:05 +00:00
Treehugger Robot
09441e4649 Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933 am: 54f00b323c
Change-Id: I51a8c7a63a22711d5fc17451f7e6e17316f885ea
2020-05-20 19:32:06 +00:00
Treehugger Robot
54f00b323c Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933
Change-Id: I3e9273248eee211fcc5c29f4399a82addbaf0291
2020-05-20 19:14:53 +00:00
Treehugger Robot
3de360b933 Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" 2020-05-20 18:57:44 +00:00
Raman Tenneti
3a9f54cee8 Revert "Messaging: Show quick reply choices only on wearable devices"
This reverts commit dffc4fa578.

Reason for revert: Reverting per Taesu Lee's comments - https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1259839

@Raman,
This new feature still doesn't work properly.
As we know Luca has been submitted CL:1271087 and CL:1271088 to fix it. But it still has issues.

Change-Id: I2e8eb1fce302b12f3f30b8163da7e749c08733d9
2020-05-19 22:17:39 +00:00
Taesu Lee
aedb8b69e9 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1 am: 925e555dd6
Change-Id: I0914fe244002a0b24359280ca56f3094dc2a5b1c
2020-05-19 01:26:23 +00:00
Taesu Lee
925e555dd6 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1
Change-Id: I573a2677ae98dbab953bb5bef67b99d95610ff41
2020-05-19 01:08:32 +00:00
Taesu Lee
1e144034d1 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587
Change-Id: I5604cfaa4a27fdf75cc4c092650988161b18d23c
2020-05-19 00:52:59 +00:00
Taesu Lee
3bf899c587 Rescheduling pending messages after outside window failure am: 0ff700cea4
Change-Id: I84881b6b958ea11fc42c2e8c6b21d0b29b8fef64
2020-05-19 00:39:33 +00:00
Taesu Lee
0ff700cea4 Rescheduling pending messages after outside window failure
No more rescheduling for pending messages after DownloadMmsAction is
failed caused by outside window. Any pending download messages will be
remained as the DOWNLOADING state without actual downloading operations
and sending a DEFERRED M-NotifyResp.ind even.
It will reschedule pending messages whenever sending or downloading is
failed including outside window failure case. And it also removes dup
scheduling and fix some typo.

Test: Manual

Change-Id: Ie37088347c69f25d838875830fc65ce7727fefe6
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-18 13:16:50 +09:00
Taesu Lee
3727f330af Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a am: 2393df67e4
Change-Id: I7596f66873a44213d14fcc807a788d2a90cda5b2
2020-05-08 18:40:34 +00:00
Taesu Lee
2393df67e4 Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a
Change-Id: Ib018f30bd8592fa61eada8ce5c81ce59b8d60de6
2020-05-08 18:25:33 +00:00
Taesu Lee
fc61c91c8a Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166
Change-Id: I7a06e4b055021fce0a34bb1d03f7ab629c46c832
2020-05-08 18:07:30 +00:00
Taesu Lee
2cbca58166 Fix NPE on MultiConversationNotificationState am: 9635b646d8
Change-Id: If8596050a9463200ea5244db1051a6ce4082e047
2020-05-08 17:55:19 +00:00
Taesu Lee
9635b646d8 Fix NPE on MultiConversationNotificationState
Use the most recent notification's state to print out log because
mContent is null in case of a notification for multiple messages in at
least 2 different conversations.
And no need sanitizePII() since this log is only for VERBOSE already.

Test: 1) adb shell setprop log.tag.MessagingAppNotif VERBOSE
      2) Receive SMS from different senders

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ie300620f0014577ca65b9a7e3a4c397a39717992
2020-05-08 19:01:59 +09:00
Taesu Lee
38e2bfd4f8 Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76 am: 9d2baa4eba am: 3466711399
Change-Id: I4b9ec80d1643c18e6a1370f8bb3c65059e981e24
2020-05-05 03:14:23 +00:00
Taesu Lee
279939c621 Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468 am: 07c87d9e1b am: d982d11e82
Change-Id: Ia9cca8e01428c17c4e68c7a9f7bf62dc5b179c5a
2020-05-05 03:14:13 +00:00
Taesu Lee
d1c27b6956 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b am: e6c7e23828 am: 797aa42f35
Change-Id: I73b39caa0e6fa39bf4d81740e7ef1df418d6e81a
2020-05-05 03:14:12 +00:00
Taesu Lee
3466711399 Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76 am: 9d2baa4eba
Change-Id: Ic5f1b270b6d667bd281cc9f2db44d3de081cb8e8
2020-05-05 02:55:28 +00:00
Taesu Lee
d982d11e82 Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468 am: 07c87d9e1b
Change-Id: I7896b05e32fc5e2c554e4c56358e4367acec3437
2020-05-05 02:55:22 +00:00
Taesu Lee
797aa42f35 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b am: e6c7e23828
Change-Id: I59e8fe10a0e419d6ddb008edf1533d43164714ba
2020-05-05 02:55:19 +00:00