Commit Graph
890 Commits
Author SHA1 Message Date
Taesu Lee 5538d47259 Remove advanced category if no preference am: 392850a825 am: 34ebed2bba am: 45cd97eabf
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Ic6105759c8b90ffcce82c12e70e962e19b50bbd5
2020-06-26 17:15:23 +00:00
Taesu Lee 45cd97eabf Remove advanced category if no preference am: 392850a825 am: 34ebed2bba
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: I40e97e119cfefaf90e14efad2760e9e31a46a9b8
2020-06-26 17:00:47 +00:00
Taesu Lee 34ebed2bba Remove advanced category if no preference am: 392850a825
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Icbed01452b088198a11436aad233c281b4068067
2020-06-26 16:48:17 +00:00
Taesu Lee 392850a825 Remove advanced category if no preference
Test: In debug mode, turn off all the configs for advanced category

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I52ea0905b9d4f03a57b4849e5b575bc5e508dd2d
2020-06-26 19:25:05 +09:00
Raman Tenneti 3debc351f5 AOSP/Messaging - Changed minSdkVersion to 19. am: 8926653a98 am: 58d5681edd am: cc4904c89a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: I7e52857f5f9f31222eb425c8ccd969643051732e
2020-06-23 23:53:38 +00:00
Raman Tenneti cc4904c89a AOSP/Messaging - Changed minSdkVersion to 19. am: 8926653a98 am: 58d5681edd
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: I31114ab0e25fc0c2352a42ec2202459730c4bf0a
2020-06-23 23:40:39 +00:00
Raman Tenneti 58d5681edd AOSP/Messaging - Changed minSdkVersion to 19. am: 8926653a98
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: Icbbf5bf2bfa0e59e75fb0a0e87a928ee1fe93bf8
2020-06-23 23:16:24 +00:00
Raman Tenneti 8926653a98 AOSP/Messaging - Changed minSdkVersion to 19.
Bug: 159055957

Test: manual - Tested the messaging UI.

$ make -j 40

Change-Id: I6f89161d7c841e88fcd8496417ae1ab8e964961a
2020-06-23 22:10:34 +00:00
Treehugger Robot 945d572d39 Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c269813 am: 92b38533ec am: d43f2fd23c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: I861686e60742c88d1cc9dc93c0bdc2d1cc01d862
2020-06-22 17:21:26 +00:00
Taesu Lee 43f98b38f0 Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb am: 5c393695c6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: Ia252373a2a6109a881feee44a5d20be6e5aec464
2020-06-22 17:21:11 +00:00
Treehugger Robot d43f2fd23c Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c269813 am: 92b38533ec
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: I32963ac99c68803399349b0c4e1f54b9621ba76c
2020-06-22 17:06:51 +00:00
Taesu Lee 5c393695c6 Fix app initialization issue if no permissions am: 297a6f7047 am: ba59a36fdb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: I2dd1a3cc46f51f2ca743674bab363c6e90f5f0ad
2020-06-22 17:06:36 +00:00
Treehugger Robot 92b38533ec Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c269813
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: If661b26336c80e6c4928afd9adc2111eb2a255ee
2020-06-22 16:53:21 +00:00
Taesu Lee ba59a36fdb Fix app initialization issue if no permissions am: 297a6f7047
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: If592a8e5431035c8a369917f24dbdd73e28bae4d
2020-06-22 16:53:14 +00:00
Treehugger Robot be4c269813 Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" 2020-06-22 16:38:07 +00:00
Taesu Lee 615ebb9dd6 Fix SecurityException at getActiveSubscriptionInfoList() on N and O
Creating ConnectivityUtil instances after checking the minimum set of
permissions since SubscriptionManager#getActiveSubscriptionInfoList()
requires READ_PHONE_STATE and users can revoke the permission.
On P and beyond, the subscription list will be filtered instead when no
permission.

Bug: 159421050
Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iafc3c57060e1893a91e629b1b3e3ba9ad78967cb
2020-06-22 19:15:39 +09:00
Taesu Lee 297a6f7047 Fix app initialization issue if no permissions
Call onRequiredPermissionsAcquired() before calling redirect() so that
BugleApplication initialization can be done completed always even
PermissionCheckActivity#onResume() case.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I01bb681442e0b391238bc162ce139ff40d947eaf
2020-06-22 19:14:52 +09:00
Raman Tenneti b3a5b916d8 AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54ece am: f556ac71f2 am: 5850cee247
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: I29dbf1772abf8f94fee7dd27bebc4b0de2b753ce
2020-06-20 00:02:42 +00:00
Raman Tenneti 5850cee247 AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54ece am: f556ac71f2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: Id215ca02976858312f465f78e70eedb7d371317f
2020-06-19 23:50:53 +00:00
Raman Tenneti f556ac71f2 AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54ece
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: Idaac2e53f28bde3bd2d88c484744308130d5b4d0
2020-06-19 23:37:46 +00:00
Raman Tenneti 7f4bb54ece AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI.
Fixes error: "NoSuchFieldError exception: Telephony.Carriers.SIM_APN_URI requires API level 29"

Bug: 159055957

Test: manual - Tested the messaging UI. Without this change the app is crashing when we click on it.

$ make -j 40

Change-Id: Ic34ccac673531a61386c1eaa3bbfff950d19517b
2020-06-19 21:58:29 +00:00
Treehugger Robot 454d3fe0c6 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c am: ea97b36d27 am: f33a0d0823
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: I03c2befd38b5e2d998b77d2e0a642278b01e0d05
2020-06-19 17:30:45 +00:00
Taesu Lee 298adffd13 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742 am: 619f7547d3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I5433d17c76decd475b357d0ebefc83b53dc29098
2020-06-19 17:30:36 +00:00
Treehugger Robot f33a0d0823 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c am: ea97b36d27
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: Ibd799529f6cef95614f2bef54ad8a9f59e7df125
2020-06-19 17:16:39 +00:00
Taesu Lee 619f7547d3 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a am: 5db150a742
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: I7ea06fcff9be951ae5994ca1d9fc5d7d1efe648e
2020-06-19 17:16:27 +00:00
Treehugger Robot ea97b36d27 Merge "Fix handling format based on API level accordingly." am: d626bcaf0c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343463

Change-Id: I71a236a34be90808809c85bbe062e6452fb06afa
2020-06-19 17:04:32 +00:00
Taesu Lee 5db150a742 Remove only one Lambda Exp for JAVA 7 am: 0c7ab8c20a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343464

Change-Id: If165c85253bfd9bdcc2c3939def095968796fe83
2020-06-19 17:04:20 +00:00
Treehugger Robot d626bcaf0c Merge "Fix handling format based on API level accordingly." 2020-06-19 16:55:25 +00:00
Taesu Lee 0c7ab8c20a Remove only one Lambda Exp for JAVA 7
Remove a Lambda Exp and replace ConcurrentHashMap#computeIfAbsent() with
containsKey() and put() so that this app can be built using JAVA 7.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I7ff8a3b5fc4673dfe05c5ecc9418d377f3ed4f2e
2020-06-19 19:30:58 +09:00
Taesu Lee bd3b711aca Fix handling format based on API level accordingly.
Use SmsMessage#createFromPdu(pdu, format) at least on M and replace
SmsMessage#FORMAT_3GPP2 with "3gpp2".
 - SmsMessage#createFromPdu(pdu, format) is added in API level 23.
 - SmsMessage#FORMAT_3GPP2 is added in API level 28.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Icab2c6c3c86ee8b6597881bfac6066fed60db4d2
2020-06-19 18:34:20 +09:00
Taesu Lee d5a77b3938 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6 am: d810c8b49e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: I46cbce580c764748726666b3febe3b07f4633b5a
2020-06-18 17:53:52 +00:00
Taesu Lee d810c8b49e Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3 am: 86314ff8e6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Icc9cbfc22b10f73726ea7230c0e463d459c1830b
2020-06-18 17:40:18 +00:00
Taesu Lee 86314ff8e6 Fix creating ConnectivityUtil to work on any platform am: dcfe928ff3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1343457

Change-Id: Id737b6239df8b85888e7832ab6f5e157be94de1f
2020-06-18 17:27:52 +00:00
Taesu Lee dcfe928ff3 Fix creating ConnectivityUtil to work on any platform
After this CL, ConnectivityUtil for default subId is used again on pre
N because TelephonyManager has createForSubscriptionId() for a specific
subId from N.
Nevertheless, listen() uses the default subId on PhoneStateListener
instead of the subId on the manager still even N. On O and beyond,
ConnectivityUtil works correctly on multi-sim devices.

Revert "Fix missing computeIfAbsent() method in L_MR1 and M"

This reverts commit f0ccb76d8d.

Reason for revert: Manage ConnectivityUtil instances for subIds at least
                   on N instead.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I2f08928a6798a2ce275c5c75569ad379999d274c
2020-06-18 19:24:27 +09:00
Treehugger Robot db44cbe6db Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I6fade445937470598e0b09f1ae73e8e535530684
2020-06-17 16:53:08 +00:00
Treehugger Robot 69cd91a75f Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: Iaccb9a0bfe078bb3712c875e30877bd2e0bdf1d2
2020-06-17 16:35:40 +00:00
Treehugger Robot feaad2df13 Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I4bdfca1d8b537b3940eec4ecf1a166b78589b2db
2020-06-17 16:22:59 +00:00
Treehugger Robot db1ebc265c Merge "Fix missing computeIfAbsent() method in L_MR1 and M" 2020-06-17 16:15:32 +00:00
Taesu Lee f0ccb76d8d Fix missing computeIfAbsent() method in L_MR1 and M
Replace ConcurrentHashMap#computeIfAbsent() with containsKey() and put()
since computeIfAbsent() is added in API level 24.

Bug: 158846265
Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I3c43f0d7b1f289f0442c9359de4f099217244387
2020-06-17 19:03:26 +09:00
Taesu Lee 3aae6cf088 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I42852de2576cff4a5582e5b05623cbf22716a9dc
2020-06-16 16:52:42 +00:00
Taesu Lee 742b382d83 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Ied8b839de8e07d04c89be7c24aaf8ea387a663d1
2020-06-16 16:45:35 +00:00
Taesu Lee b9dd11dd77 Remove unnecessary methods from MmsUtils am: c9e85fd21a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I6359187593ac39b7bbd1628cab743586515f72e8
2020-06-16 16:23:53 +00:00
Taesu Lee c9e85fd21a Remove unnecessary methods from MmsUtils
Same methods in PhoneUtils are used everywhere instead.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia17c1f17511c53a9235af462fa0809146726e89f
2020-06-16 11:00:42 +09:00
Taesu Lee d851c2f7f0 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Ie80fb55d3080d7f7f1f4c4dcb49aef84d09e2ee8
2020-06-11 19:29:09 +00:00
Taesu Lee c3e125df64 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I4310dfdbf854572427d43d87a4c31702a36a1598
2020-06-11 19:16:35 +00:00
Taesu Lee d067695cd8 Allow call to phone numbers or voice mail numbers only am: 8b347325fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Iaa1761772b4e7991e009fce48e692a99ebe09150
2020-06-11 19:05:57 +00:00
Taesu Lee 8b347325fa Allow call to phone numbers or voice mail numbers only
It allows to call to well-formatted phone numbers or carrier specific
phone numbers starting with star sign such as *20 so that user can make
a call directly in a conversation for voice mail SMSs.

Revert "Check whether dialable only"

This reverts commit dbc43316cf.

Reason for revert: a call icon is disappeared for well-formatted phone
                   number with parentheses, dash and etc.

Test: Check the call icon in conversations for phone numbers and voice
      mail numbers.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I1b279f8a5372b00a5a0c572f9969731f1e633389
2020-06-11 18:56:04 +09:00
Taesu Lee 8a2358c4d5 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I55dfb1611ea32b9318cae568a75f89b4ba77635d
2020-06-08 17:40:30 +00:00
Taesu Lee 2f60034413 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: Idd83c8097c70305e74bf86bf0b61df48e3115fd3
2020-06-08 17:25:09 +00:00
Taesu Lee 638c7a6817 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: If82c2db8dc767a806360c91c55a056cddd2f06a9
2020-06-08 17:08:29 +00:00