Commit Graph
608 Commits
Author SHA1 Message Date
Taesu Lee 4e99cc0a02 ProcessPendingMessagesAction works based on subscriptions
PorcessPendingMessagesAction queues one message for sending/downloading
associated with a subscription triggering current action at a time. And
the ConnectivityUtil also works based on subscriptions so that pending
messages can be processed regardless of other phones' state in multi-sim
case.

It includes cleanup code as well.

Test: Manual

Change-Id: Id6b4f4a0aa6a3291e7a4d8a5d3f0fbb9db3c5b86
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-28 18:16:54 +09:00
Treehugger Robot 4e84ad49bb Merge "Allow intent shared subject or title to be mms subject" 2020-02-24 20:54:01 +00:00
Marco Sirabella c5cb15c9d8 Allow intent shared subject or title to be mms subject
Test: m, manual
Change-Id: Ibb5eba030320467774cdac1d502ec36c98abcb43
2020-02-22 02:41:01 +00:00
Julien Desprez 51262f2a8a Merge "Update runner to AndroidJUnittest" 2020-02-22 02:32:05 +00:00
Julien Desprez fc35b1cb99 Update runner to AndroidJUnittest
There is no reason to use the base class for
instrumentations.

Test: Make
Bug: 150008527
Change-Id: I1e5ec7a4edb8b764deb006e95ca4fd55b9127606
2020-02-21 13:34:25 -08:00
Taesu Lee a8b76eafc4 Allow acceptable media types only for sharing
Test: Manual

Change-Id: I20d5f8abf2ba7b7b620aa2a4ec1e0a43091f98c2
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-20 08:52:53 +09:00
Taesu Lee 2716c26c23 Support audio attachments through GalleryMediaChooser
GalleryMediaChooser supports audio types also. It displays simple audio
icon and file info for audio files on grid views.

Test: Manual

Change-Id: I98b605156af3c1909c0141a2b99380b5da11c1e2
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-20 08:52:44 +09:00
Taesu Lee 6c77158718 Support video attachments through GalleryMediaChooser
GalleryMediaChooser supports video types and more image types also. And
video thumbnails are overlaid with the play button image to distinguish
between images and videos.

Note:
 1. EXTRA_ALLOW_MULTIPLE is not specified for ACTION_GET_CONTENT.
 2. Files, methods and variables' name are still including "image".
 3. Content descriptions are not updated.

Test: Manual

Change-Id: I961928f150e4ae8ee80a1fba2f20c37fb5426669
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-19 18:36:32 +09:00
Taesu Lee a531636ae3 Do not show the fail icon for a group conversation
Test: Check an widget

Change-Id: Ie1ea35e0bd36891abf8b476b5409a99fa439a1b6
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-18 15:53:06 +09:00
Taesu Lee 519ae7e902 Show attachments size during composing MMS
It shows attachments size during composing MMS.
Note: Images could be resized before sending.

Test: Manual

Change-Id: I63eafe0d57259a7742ab839c4d96d595675e70e9
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-18 15:53:06 +09:00
Taesu Lee c00d290df7 Actual attachments size is the minimum size except images
Only images can be compressed before sending. Actual size got from a
content uri is used for computing the minimum size for others.

Test: Manual

Change-Id: Id8d6ec24f80fe0eae70b6b1686ca7b199c70e313
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-17 12:08:45 +09:00
tnmy-cyngn c12077e4fb Messaging app crashes after a few MMS
In some scenarios, data not bound when SIM state
change local broadcasts are received. See stacktrace
for more info. Protect against/skip call to update()
in such scenarios.

Test: m
Change-Id: Iee7775a74d22808cb262e8973ca70e5e1f0acfc9
Bug-Id: CYNGNOS-3062, KIPPER-718
2020-02-12 20:36:52 +01:00
Danny Baumann bbda7af9d3 Fix menu item highlight color.
Test: m
Change-Id: Ia5852a4de95ff355c6f2cd8275002d3c5cfb8370
2020-02-12 20:34:20 +01:00
Diogo Ferreira 91abcc6c8e MessageQueue: Process pending messages per subscription
The message dispatcher will only queue one message at a time for
both sending and downloading. On multi-sim scenarios this causes
failures in a subscription to delay all messages added after the
one that fails.

This patch changes the pending messages processor to queue one
message per subscription for both sending and received, instead of
one globally.

Test: m
Change-Id: Ia54906089dccbbe694aab7bf995ac08480d3e4f8
Ticket: CRACKLING-877
2020-02-12 20:33:56 +01:00
Altaf-Mahdi cce5e8de2f Messaging: change Avatar fontFamily to sans-serif-medium
Match the changes in ContactsCommon

Test: m
Change-Id: Ica94f00e6121c550ea0bc1dfe73a52162dccda71
2020-02-12 20:33:53 +01:00
Taesu Lee 050bc461fc Fix android.os.strictmode.LeakedClosableViolation
Test: Check log.

Change-Id: I488fc6c4288bc3843a2be35a8e2988738441263e
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-12 09:54:01 +09:00
Treehugger Robot ce85205894 Merge "Fix to show PersonItemView for TYPE_CHOOSER_GRID correctly" 2020-02-11 22:31:28 +00:00
Treehugger Robot 9d1aeb4d80 Merge "Register implicit broadcasts at runtime for updating widgets" 2020-02-11 22:17:58 +00:00
Treehugger Robot c91db32cf3 Merge "Fix wrong margin on widget conversation view" 2020-02-11 22:14:56 +00:00
Taesu Lee 711bed5c23 Register implicit broadcasts at runtime for updating widgets
It resolves Broadcast Limitations issue if target API level is changed
as 26 or higher later.
It includes fixing code style also.

Test: Check messaging widgets' changes.

Change-Id: I6e08027b1d6a5a19cfd17f8ec3e9a895dbb3c44a
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-11 15:12:01 +09:00
Taesu Lee 1de47c7705 Fix to show PersonItemView for TYPE_CHOOSER_GRID correctly
Use match_parent instead.

Test: Check grid views for a vcard on AttachmentChooserFragment.

Change-Id: I60acc77d9c0cd9608187d86f71fc4d2c7e78afb7
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-11 15:03:12 +09:00
Taesu Lee 5e81c84ee9 Fix covering issue for video thumbnails on widget view
Use ic_video_play_light.png having background transparent to show the
video thumbnails correctly.

Test: Check a widget for conversations including a video attachment.

Change-Id: I1333a3be41e53ce7e8ad1a64849e726c73cda153
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-11 15:02:30 +09:00
Taesu Lee f3ae4c19fb Fix wrong margin on widget conversation view
Change layout_marginTop as -2dp to enclose message_list between top_line
and bottom_line.

Test: Check a widget for conversations.

Change-Id: I097303134e8ea079de39ac18746a51e1937b92c3
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-11 15:02:12 +09:00
Treehugger Robot e8827131fc Merge "Support sharing with image/video/audio/vcard and text fully" 2020-02-07 03:09:52 +00:00
Taesu Lee defea9dea1 Support sharing with image/video/audio/vcard and text fully
ACTION_SEND and ACTION_SEND_MULTIPLE support image, video, audio, text
and vcard files.

Test: Manual

Change-Id: I1c08070f89877140aba9087717bb663ee2990467
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-07 08:55:20 +09:00
Treehugger Robot 47bcb7f2a7 Merge "Fix bad RecyclerView issue" 2020-02-06 22:21:08 +00:00
Treehugger Robot d3ea4ec384 Merge "Fix NPE caused by invalid IFD0 offset" 2020-02-06 20:51:01 +00:00
Treehugger Robot 5c8f5fdeb1 Merge "Use file extension based on MIME type" 2020-02-06 20:41:08 +00:00
Taesu Lee 0770975c8a Use file extension based on MIME type
It uses the most common extension for the given MIME type.

Test: Manual

Change-Id: I3d4aea85fcd42088ed19898054db7225954d3401
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-05 16:08:02 +09:00
Taesu Lee 36a41d3e9d Fix showing wrong image on document picker item
Set mDetachedRequestDescriptor as null for document picker to prevent
calling setImageResourceId() in onAttachedToWindow().

Test: Manual

Change-Id: Ied5ca200cac350ef4b2420269763dfc240fc97c4
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-05 15:53:23 +09:00
Taesu Lee 3d6d1f6193 Fix bad RecyclerView issue
dispatchAddFinished() must be called by subclasses when done, either
immediately(if no animation will occur) or after the animation actually
finishes.

Test: Manual

Change-Id: I72b9da41f52b381e3531842aa1fb07e573c120cb
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-05 15:51:43 +09:00
Taesu Lee 710fe2f2ae Fix NPE caused by invalid IFD0 offset
NPE occurs when current IFD0 offset is smaller than default IFD offset.
Just skip invalid tag instead.

Test: Manual

Change-Id: I184794e7ee227849da7d2ecf3cf647e69dc91610
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-02-05 15:47:13 +09:00
Bill Yi 3bd7b79daa Import translations. DO NOT MERGE
BUG:148403740

TEST: m messaging

Change-Id: I4b74a267c0ed7cffe04d97ca465f2aa90ae1847a
Auto-generated-cl: translation import
2020-01-27 16:55:48 -08:00
Xin Li 8f27830d2d DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master
Bug: 142003500
Change-Id: If59160cc7c40fde5577b2aa82feb041c0086e8cf
2019-10-30 11:49:53 -07:00
Xin Li a761701291 [automerger skipped] Merge qt-r1-dev-plus-aosp-without-vendor (5817612) into stage-aosp-master am: d69430249d -s ours
am: e5eb582943 -s ours
am skip reason: change_id I7624257e4cffc690f0df4c844b23cd2accddca4b with SHA1 105542679f is in history

Change-Id: Ie6f217bd119e850ce3d34ab9829f3a686e48259b
2019-09-08 15:26:42 -07:00
Xin Li e5eb582943 [automerger skipped] Merge qt-r1-dev-plus-aosp-without-vendor (5817612) into stage-aosp-master
am: d69430249d -s ours
am skip reason: change_id I7624257e4cffc690f0df4c844b23cd2accddca4b with SHA1 105542679f is in history

Change-Id: Ic45c1b4f5797f751986f2e6654738c9e778209cc
2019-09-08 14:43:58 -07:00
Xin Li d69430249d Merge qt-r1-dev-plus-aosp-without-vendor (5817612) into stage-aosp-master
No content change.

Bug: 135460123
Change-Id: I5e64e969936dbbae86d0d71cbad524fb24973af1
Merged-In: I7624257e4cffc690f0df4c844b23cd2accddca4b
2019-09-08 12:45:15 -07:00
Xin Li 025b5c8ef0 [automerger skipped] DO NOT MERGE - Merge Android 10 into master am: 105542679f -s ours am: 2f8008876a
am: 0e1562408a

Change-Id: Ieda91c49c2f3ec3fde2a6b180b7c38f8bea149f0
2019-09-05 13:35:28 -07:00
Xin Li 0e1562408a [automerger skipped] DO NOT MERGE - Merge Android 10 into master am: 105542679f -s ours
am: 2f8008876a

Change-Id: I0f96f85edfe4bf6aa3a62a2267e27eb66fd5ce6d
2019-09-05 12:59:18 -07:00
Xin Li 2f8008876a [automerger skipped] DO NOT MERGE - Merge Android 10 into master
am: 105542679f -s ours
am skip reason: subject contains skip directive

Change-Id: I04b43539e52eae8fd96dc98f36a202c3584d29f4
2019-09-05 12:13:27 -07:00
Xin Li 105542679f DO NOT MERGE - Merge Android 10 into master
Bug: 139893257
Change-Id: I7624257e4cffc690f0df4c844b23cd2accddca4b
2019-09-04 13:34:31 -07:00
Po-Chien Hsueh 99d9b31889 Move libgiftranscode.so to /product am: 003eb4915a am: 90d0edb3dc am: 7e674a30d8
am: 0e55713ba0

Change-Id: I9683705c8825af0afc79ac27bc2b8e539573d351
2019-08-15 19:39:16 -07:00
Po-Chien Hsueh 0e55713ba0 Move libgiftranscode.so to /product am: 003eb4915a am: 90d0edb3dc
am: 7e674a30d8

Change-Id: I16069c6c80abf267fabec6f220509b9c4bf8e3d9
2019-08-15 19:26:42 -07:00
Po-Chien Hsueh 7e674a30d8 Move libgiftranscode.so to /product am: 003eb4915a
am: 90d0edb3dc

Change-Id: I01cdeb2cdb14602330b2958b8d1b4e467563558b
2019-08-15 19:04:42 -07:00
Po-Chien Hsueh 90d0edb3dc Move libgiftranscode.so to /product
am: 003eb4915a

Change-Id: I6130ee3cfcd9b199aaad85cc555c3931f2bb4ce1
2019-08-15 18:49:32 -07:00
Po-Chien Hsueh 003eb4915a Move libgiftranscode.so to /product
libgiftranscode.so is a jni lib for Messaging app, which is usually
overridden by proprietary apps on shipping devices. We have moved
Messaging to /product. Now this CL move libgiftranscode.so too.

Bug: 138282284
Test: Open gif files with Messaging on aosp_crosshatch
Change-Id: Ic104ba8ec5c2258a28c8d19151a00f6c601b5f80
2019-08-15 16:20:06 +08:00
Xin Li bcf3a7354c [automerger skipped] DO NOT MERGE - Skip qt-dev-plus-aosp-without-vendor (5713463) in stage-aosp-master am: e051816567 -s ours am: 893d1265ad
am: 9e95d7a4f7

Change-Id: I7c76f6787472d06f624570d9ae172928389dec23
2019-08-14 14:23:26 -07:00
Xin Li 9e95d7a4f7 [automerger skipped] DO NOT MERGE - Skip qt-dev-plus-aosp-without-vendor (5713463) in stage-aosp-master am: e051816567 -s ours
am: 893d1265ad

Change-Id: I9d7d07738190030ebfde126ca3a6a531feafa144
2019-08-14 13:56:47 -07:00
Xin Li 893d1265ad [automerger skipped] DO NOT MERGE - Skip qt-dev-plus-aosp-without-vendor (5713463) in stage-aosp-master
am: e051816567 -s ours
am skip reason: subject contains skip directive

Change-Id: Ib8d5be333c2d3f87580ed909e5d9a19bb671d44a
2019-08-14 13:32:01 -07:00
Xin Li e051816567 DO NOT MERGE - Skip qt-dev-plus-aosp-without-vendor (5713463) in stage-aosp-master
Bug: 134405016
Change-Id: Ib7d990ceba3732de79765f7edf9d27111cbe4bab
2019-08-14 11:35:20 -07:00