Commit Graph
778 Commits
Author SHA1 Message Date
Taesu Lee 1e144034d1 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587
Change-Id: I5604cfaa4a27fdf75cc4c092650988161b18d23c
2020-05-19 00:52:59 +00:00
Taesu Lee 3bf899c587 Rescheduling pending messages after outside window failure am: 0ff700cea4
Change-Id: I84881b6b958ea11fc42c2e8c6b21d0b29b8fef64
2020-05-19 00:39:33 +00:00
Taesu Lee 0ff700cea4 Rescheduling pending messages after outside window failure
No more rescheduling for pending messages after DownloadMmsAction is
failed caused by outside window. Any pending download messages will be
remained as the DOWNLOADING state without actual downloading operations
and sending a DEFERRED M-NotifyResp.ind even.
It will reschedule pending messages whenever sending or downloading is
failed including outside window failure case. And it also removes dup
scheduling and fix some typo.

Test: Manual

Change-Id: Ie37088347c69f25d838875830fc65ce7727fefe6
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-18 13:16:50 +09:00
Taesu Lee fc61c91c8a Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166
Change-Id: I7a06e4b055021fce0a34bb1d03f7ab629c46c832
2020-05-08 18:07:30 +00:00
Taesu Lee 2cbca58166 Fix NPE on MultiConversationNotificationState am: 9635b646d8
Change-Id: If8596050a9463200ea5244db1051a6ce4082e047
2020-05-08 17:55:19 +00:00
Taesu Lee 9635b646d8 Fix NPE on MultiConversationNotificationState
Use the most recent notification's state to print out log because
mContent is null in case of a notification for multiple messages in at
least 2 different conversations.
And no need sanitizePII() since this log is only for VERBOSE already.

Test: 1) adb shell setprop log.tag.MessagingAppNotif VERBOSE
      2) Receive SMS from different senders

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ie300620f0014577ca65b9a7e3a4c397a39717992
2020-05-08 19:01:59 +09:00
Taesu Lee 9d2baa4eba Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76
Change-Id: I8e2d4c95480dce4b8d7a38a7f0c887074844d342
2020-05-05 02:32:49 +00:00
Taesu Lee 07c87d9e1b Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468
Change-Id: I64a6bd67b9b2efde2c0dbdb2b90eb35c07073404
2020-05-05 02:32:44 +00:00
Taesu Lee e6c7e23828 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b
Change-Id: I9eb3ce74f6381cdd289527d36e2ea02bfb47d345
2020-05-05 02:32:42 +00:00
Taesu Lee 78df54ed76 Hide APN prefs if platform APIs are used am: 95ceb12cdb
Change-Id: Ibd5a687a22678136634a80fb86dde41f94c76e2d
2020-05-05 02:14:59 +00:00
Taesu Lee ef2f7ec468 Use ic_add_white for consistency instead am: 116073d016
Change-Id: Ied38bf821dc213af56717f8563129245714c0cc8
2020-05-05 02:14:53 +00:00
Taesu Lee 9af5c7183b Fix to show APN prefs correctly am: 14853cb490
Change-Id: Ife9a0aa4272d91766b146d241fec43184e59862f
2020-05-05 02:14:51 +00:00
Taesu Lee 95ceb12cdb Hide APN prefs if platform APIs are used
The APN prefs is available if legacy APIs are used with local APN db
only.

Test: Manual

Change-Id: I5883dcb2c406acc601787edd02e0d3272732e6d7
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 19:30:12 +09:00
Taesu Lee 116073d016 Use ic_add_white for consistency instead
Test: Check "New APN" icon in ApnSettingsActivity.

Change-Id: I0fc29384e0714a780842652178e3e88ff311456a
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 18:48:30 +09:00
Taesu Lee 14853cb490 Fix to show APN prefs correctly
Test: Settings -> Advanced -> Access Point Names

Change-Id: Ia3ad443ac056a877abd6cd258c2219d8ee6ff181
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 18:48:30 +09:00
Taesu Lee 1292ae05a2 Fix NPE am: 1a0f1591de am: 23197e5729
Change-Id: Ifd170a74c57a08120b485fa8bd970c4ed3b96928
2020-04-28 16:11:47 +00:00
Taesu Lee 23197e5729 Fix NPE am: 1a0f1591de
Change-Id: Iff2bc970a78fc37f2b7721dbd651983dcf692b52
2020-04-28 15:57:27 +00:00
Taesu Lee 1a0f1591de Fix NPE
Check whether SMS delivery report preference is available first because
it could be removed if carriers don't support it.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I9e0049dd61713f7a9638fb19a37aaa261f35d768
2020-04-28 17:28:42 +09:00
Taesu Lee 3548c16d15 Handle delivered messages as completed messages am: 7ccb748e61 am: cbcb1628e5
Change-Id: I81749b4559f16731a009772cb52bc83e63056d80
2020-04-27 18:33:10 +00:00
Taesu Lee cbcb1628e5 Handle delivered messages as completed messages am: 7ccb748e61
Change-Id: I202ce5f8a2a72f763a56c98708045c10550a8d73
2020-04-27 18:21:48 +00:00
Taesu Lee 7ccb748e61 Handle delivered messages as completed messages
Delivered messages could be forwarded and sent time can be shown on
MessageDetailsDialog.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I6e24bdfe6a037ab588914327dbd8abf3f30512ea
2020-04-24 10:22:39 +09:00
Xin Li 67be3bbf79 [automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 85eaa3e1ec -s ours
am skip reason: subject contains skip directive

Change-Id: I90519048d9c855d8828ac647544d2653d345cbf6
2020-04-10 03:06:10 +00:00
Xin Li 85eaa3e1ec DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master
Bug: 151763422
Change-Id: Ic576a0fc228b600ee5865f70ec431c234d331786
2020-04-09 17:51:16 -07:00
Taesu Lee 2ead48c6da Dismiss SnackBar when detached am: aa23161c03 am: 5c67dbb0d2
Change-Id: I92ebff9808c8df5625a3e542d0cae6e28a9a9c80
2020-04-02 21:37:41 +00:00
Taesu Lee 57e6f108c7 Dismiss SnackBar when detached am: aa23161c03 am: 5c67dbb0d2
Change-Id: Ib551d5788a2294374b892e8ad88448ba420b8aa7
2020-04-02 21:36:48 +00:00
Taesu Lee 5c67dbb0d2 Dismiss SnackBar when detached am: aa23161c03
Change-Id: Ib76ae11b7456549bfcb64710486da59bd56c2b34
2020-04-02 21:17:52 +00:00
Taesu Lee aa23161c03 Dismiss SnackBar when detached
SnackBarManager state is not cleared when SnackBar is detached from a
window without dismiss(). After then it is remained as dismissing state
forever.

Test: 1) Long-press a conversation and click archive action.
      2) Press back key before the snackbar is dismissed.
      3) Repeat 1) and check the snackbar is shown or not.

Change-Id: Icf2cdcd30aea42685db68e5ac36436a34c9c94ae
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-04-01 09:58:13 +09:00
Treehugger Robot 3ff50dfe96 Merge "Add an exported flag in manifest" am: 90c3d807c8 am: 294fec5331
Change-Id: Ib8fb3445ced97a972e747c6af0c26c238523df51
2020-03-31 21:36:26 +00:00
Treehugger Robot 52c52239dc Merge "Add an exported flag in manifest" am: 90c3d807c8 am: 294fec5331
Change-Id: I47db37639b7a6fd86142555229055c066564a35a
2020-03-31 21:36:22 +00:00
Treehugger Robot 294fec5331 Merge "Add an exported flag in manifest" am: 90c3d807c8
Change-Id: I68762c9e73231b6d1d85ee95ff939cfc4cd5591f
2020-03-31 21:24:59 +00:00
Treehugger Robot 90c3d807c8 Merge "Add an exported flag in manifest" 2020-03-31 21:09:08 +00:00
Treehugger Robot 5fc3981ab9 Merge "Fix assert fail during onSaveInstanceState()" am: 2af5b4b045 am: 5380b1e04d
Change-Id: Id9056cecf367712a52ece3bdc95c8a6c23ff73aa
2020-03-31 20:22:06 +00:00
Han Wang 073cf866ed Messaging: Show quick reply choices only on wearable devices am: dffc4fa578 am: 3a329b53bc
Change-Id: Ic1efeb777b66ad8d579feee24fd363174b192556
2020-03-31 20:21:59 +00:00
Treehugger Robot 6076b0e44f Merge "Fix assert fail during onSaveInstanceState()" am: 2af5b4b045 am: 5380b1e04d
Change-Id: I556cb4e6d4910f07ca324a3de186718dab350d94
2020-03-31 20:21:56 +00:00
Han Wang 449c30ad6b Messaging: Show quick reply choices only on wearable devices am: dffc4fa578 am: 3a329b53bc
Change-Id: If34b0274a19c2e231cf50105d1de5b9020fd0077
2020-03-31 20:21:49 +00:00
Treehugger Robot 5380b1e04d Merge "Fix assert fail during onSaveInstanceState()" am: 2af5b4b045
Change-Id: I04f0271b96b386cb3f8f13870cb84cfee621b3ab
2020-03-31 20:11:13 +00:00
Han Wang 3a329b53bc Messaging: Show quick reply choices only on wearable devices am: dffc4fa578
Change-Id: Ibdc2f22811f1f688c8f9ae808ed8de760cde3f3f
2020-03-31 20:09:36 +00:00
Treehugger Robot 2af5b4b045 Merge "Fix assert fail during onSaveInstanceState()" 2020-03-31 19:02:43 +00:00
Taesu Lee b41ce08cab Fix assert fail during onSaveInstanceState()
Selected attachment from GalleryGridView will be destroyed when same
attachment is already existed in DraftMessageData. It will make assert
fail during onSaveInstanceState() because mDestroyed in MessagePartData
is true already.
It destroys existing attachment and replaces with new attachment instead
so that selected attachments could be maintained correctly.

Test: 1) Select one image in GalleryMediaChooser.
      2) Reopen the chooser and long-press same image again to enter to
      the multi-selection mode.
      3) Long-press the attachment on draft message to open
      AttachmentChooser.
      4) Check Assert fail.

Change-Id: I029d778779260d0097ce30bf5338fceba05e1f77
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-03-31 18:34:54 +09:00
Han Wang dffc4fa578 Messaging: Show quick reply choices only on wearable devices
Change-Id: I4b81643c051a9b1377f2046c1aa0515c590736fc
2020-03-28 14:39:04 +01:00
Ashwini Oruganti 90bdc4e447 Add an exported flag in manifest
With b/150232615, we will need an explicit value set for the exported
flag when intent filters are present, as the default behavior is
changing for S+. This change adds the value reflecting the previous
default to the manifest.

These changes were made using an automated tool, the xml file may be
reformatted slightly creating a larger diff. The only "real" change is
the addition of "android:exported" to activities, services, and
receivers that have one or more intent-filters.

Bug: 150232615
Test: TH
Exempt-From-Owner-Approval: mechanical refactoring
Change-Id: I4395aa6b40fc1b1f8e3a5f4719534a66b6e20969
2020-03-23 15:07:56 -07:00
Xin Li fdb989c500 DO NOT MERGE - Merge qt-qpr1-dev-plus-aosp@6304901 into stage-aosp-master am: 4c26c52ea3
Change-Id: I09310079f719993fbd02eb011db6ccdd6b3081a5
2020-03-20 18:32:34 +00:00
Xin Li 8948253343 [automerger skipped] DO NOT MERGE - Merge qt-qpr1-dev-plus-aosp@6304901 into stage-aosp-master am: 4c26c52ea3 -s ours
am skip reason: subject contains skip directive

Change-Id: I9c99d7bda402e893fa10c9154c9b2e134cab33d8
2020-03-20 18:32:03 +00:00
Xin Li 4c26c52ea3 DO NOT MERGE - Merge qt-qpr1-dev-plus-aosp@6304901 into stage-aosp-master
Bug: 151763422
Change-Id: I85f7f3d115fc1eb76c9f898fcf209a54a0d61e58
2020-03-19 10:10:41 -07:00
Automerger Merge Worker 17adffee66 Messaging: Add "Mark as read" quick action for message notifications am: f19e916a0d am: 959f8423b0
Change-Id: I5305acd2e53800b7a72e44e3f7c3752fb26d4b82
2020-03-17 18:23:45 +00:00
Automerger Merge Worker c0dbbca941 Messaging: Add "Mark as read" quick action for message notifications am: f19e916a0d am: 959f8423b0
Change-Id: Iabe73f6387d35d17cc380a8cf5e98e3ccc5886db
2020-03-17 18:23:41 +00:00
Automerger Merge Worker 959f8423b0 Messaging: Add "Mark as read" quick action for message notifications am: f19e916a0d
Change-Id: I42a2c9569a986169134e446d19727e8e9681bbcb
2020-03-17 18:09:14 +00:00
Paul Keith f19e916a0d Messaging: Add "Mark as read" quick action for message notifications
Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
Change-Id: I7194dca022e5062926fa35709de282721ca64320
2020-03-16 15:14:40 +01:00
Automerger Merge Worker 63f55f0a64 Merge "New interface to pick a contact as attachment" am: 1dc43f0e09 am: 274d9478af
Change-Id: Id7a3de0ecd940e9ddca07231fc1c4a84035c952e
2020-03-09 22:27:07 +00:00
Automerger Merge Worker 994ef53939 Fix WindowLeaked issue on AttachmentPreview am: 1412b40ec6 am: 7ad96ef75f
Change-Id: Ia00898ca565eef219bdfe0836a5af01b2a31ec5a
2020-03-09 22:26:49 +00:00