Commit Graph
807 Commits
Author SHA1 Message Date
Raman Tenneti 167852a942 Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb am: c67142cead am: 70a92bc8ff
Change-Id: I6bc8da07bae126270d2cf66fda847a473bd4395d
2020-05-21 00:35:32 +00:00
Raman Tenneti 70a92bc8ff Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb am: c67142cead
Change-Id: If5c7e30643ba6ce636acf98208e331a95f7a5669
2020-05-21 00:09:59 +00:00
Raman Tenneti c67142cead Revert "Messaging: Add "Mark as read" quick action for message notifications" am: eb1e0417eb
Change-Id: I631710ec3c472378ada25902c2c194dbf344fb24
2020-05-20 23:50:53 +00:00
Raman Tenneti eb1e0417eb Revert "Messaging: Add "Mark as read" quick action for message notifications"
This reverts commit f19e916a0d.

Reason for revert: Reverting per Taesu Lee's comments, because it doesn't work and has issues.

Change-Id: I778362b628f4c3ae076dd943e77dee415984fba0
2020-05-20 19:47:44 +00:00
Treehugger Robot cc45cb0c0f Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933 am: 54f00b323c am: 09441e4649
Change-Id: If3660be7889827eaff4e2234d9a4c6a73ad4bc27
2020-05-20 19:45:05 +00:00
Treehugger Robot 09441e4649 Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933 am: 54f00b323c
Change-Id: I51a8c7a63a22711d5fc17451f7e6e17316f885ea
2020-05-20 19:32:06 +00:00
Treehugger Robot 54f00b323c Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" am: 3de360b933
Change-Id: I3e9273248eee211fcc5c29f4399a82addbaf0291
2020-05-20 19:14:53 +00:00
Treehugger Robot 3de360b933 Merge "Revert "Messaging: Show quick reply choices only on wearable devices"" 2020-05-20 18:57:44 +00:00
Raman Tenneti 3a9f54cee8 Revert "Messaging: Show quick reply choices only on wearable devices"
This reverts commit dffc4fa578.

Reason for revert: Reverting per Taesu Lee's comments - https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1259839

@Raman,
This new feature still doesn't work properly.
As we know Luca has been submitted CL:1271087 and CL:1271088 to fix it. But it still has issues.

Change-Id: I2e8eb1fce302b12f3f30b8163da7e749c08733d9
2020-05-19 22:17:39 +00:00
Taesu Lee 925e555dd6 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587 am: 1e144034d1
Change-Id: I573a2677ae98dbab953bb5bef67b99d95610ff41
2020-05-19 01:08:32 +00:00
Taesu Lee 1e144034d1 Rescheduling pending messages after outside window failure am: 0ff700cea4 am: 3bf899c587
Change-Id: I5604cfaa4a27fdf75cc4c092650988161b18d23c
2020-05-19 00:52:59 +00:00
Taesu Lee 3bf899c587 Rescheduling pending messages after outside window failure am: 0ff700cea4
Change-Id: I84881b6b958ea11fc42c2e8c6b21d0b29b8fef64
2020-05-19 00:39:33 +00:00
Taesu Lee 0ff700cea4 Rescheduling pending messages after outside window failure
No more rescheduling for pending messages after DownloadMmsAction is
failed caused by outside window. Any pending download messages will be
remained as the DOWNLOADING state without actual downloading operations
and sending a DEFERRED M-NotifyResp.ind even.
It will reschedule pending messages whenever sending or downloading is
failed including outside window failure case. And it also removes dup
scheduling and fix some typo.

Test: Manual

Change-Id: Ie37088347c69f25d838875830fc65ce7727fefe6
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-18 13:16:50 +09:00
Taesu Lee 2393df67e4 Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166 am: fc61c91c8a
Change-Id: Ib018f30bd8592fa61eada8ce5c81ce59b8d60de6
2020-05-08 18:25:33 +00:00
Taesu Lee fc61c91c8a Fix NPE on MultiConversationNotificationState am: 9635b646d8 am: 2cbca58166
Change-Id: I7a06e4b055021fce0a34bb1d03f7ab629c46c832
2020-05-08 18:07:30 +00:00
Taesu Lee 2cbca58166 Fix NPE on MultiConversationNotificationState am: 9635b646d8
Change-Id: If8596050a9463200ea5244db1051a6ce4082e047
2020-05-08 17:55:19 +00:00
Taesu Lee 9635b646d8 Fix NPE on MultiConversationNotificationState
Use the most recent notification's state to print out log because
mContent is null in case of a notification for multiple messages in at
least 2 different conversations.
And no need sanitizePII() since this log is only for VERBOSE already.

Test: 1) adb shell setprop log.tag.MessagingAppNotif VERBOSE
      2) Receive SMS from different senders

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ie300620f0014577ca65b9a7e3a4c397a39717992
2020-05-08 19:01:59 +09:00
Taesu Lee 3466711399 Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76 am: 9d2baa4eba
Change-Id: Ic5f1b270b6d667bd281cc9f2db44d3de081cb8e8
2020-05-05 02:55:28 +00:00
Taesu Lee d982d11e82 Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468 am: 07c87d9e1b
Change-Id: I7896b05e32fc5e2c554e4c56358e4367acec3437
2020-05-05 02:55:22 +00:00
Taesu Lee 797aa42f35 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b am: e6c7e23828
Change-Id: I59e8fe10a0e419d6ddb008edf1533d43164714ba
2020-05-05 02:55:19 +00:00
Taesu Lee 9d2baa4eba Hide APN prefs if platform APIs are used am: 95ceb12cdb am: 78df54ed76
Change-Id: I8e2d4c95480dce4b8d7a38a7f0c887074844d342
2020-05-05 02:32:49 +00:00
Taesu Lee 07c87d9e1b Use ic_add_white for consistency instead am: 116073d016 am: ef2f7ec468
Change-Id: I64a6bd67b9b2efde2c0dbdb2b90eb35c07073404
2020-05-05 02:32:44 +00:00
Taesu Lee e6c7e23828 Fix to show APN prefs correctly am: 14853cb490 am: 9af5c7183b
Change-Id: I9eb3ce74f6381cdd289527d36e2ea02bfb47d345
2020-05-05 02:32:42 +00:00
Taesu Lee 78df54ed76 Hide APN prefs if platform APIs are used am: 95ceb12cdb
Change-Id: Ibd5a687a22678136634a80fb86dde41f94c76e2d
2020-05-05 02:14:59 +00:00
Taesu Lee ef2f7ec468 Use ic_add_white for consistency instead am: 116073d016
Change-Id: Ied38bf821dc213af56717f8563129245714c0cc8
2020-05-05 02:14:53 +00:00
Taesu Lee 9af5c7183b Fix to show APN prefs correctly am: 14853cb490
Change-Id: Ife9a0aa4272d91766b146d241fec43184e59862f
2020-05-05 02:14:51 +00:00
Taesu Lee 95ceb12cdb Hide APN prefs if platform APIs are used
The APN prefs is available if legacy APIs are used with local APN db
only.

Test: Manual

Change-Id: I5883dcb2c406acc601787edd02e0d3272732e6d7
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 19:30:12 +09:00
Taesu Lee 116073d016 Use ic_add_white for consistency instead
Test: Check "New APN" icon in ApnSettingsActivity.

Change-Id: I0fc29384e0714a780842652178e3e88ff311456a
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 18:48:30 +09:00
Taesu Lee 14853cb490 Fix to show APN prefs correctly
Test: Settings -> Advanced -> Access Point Names

Change-Id: Ia3ad443ac056a877abd6cd258c2219d8ee6ff181
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-04 18:48:30 +09:00
Taesu Lee 032518bd77 Fix NPE am: 1a0f1591de am: 23197e5729 am: 1292ae05a2
Change-Id: Ifdb16efdab9954f59ef972506fab0646ead68ab8
2020-04-28 16:23:19 +00:00
Taesu Lee 1292ae05a2 Fix NPE am: 1a0f1591de am: 23197e5729
Change-Id: Ifd170a74c57a08120b485fa8bd970c4ed3b96928
2020-04-28 16:11:47 +00:00
Taesu Lee 23197e5729 Fix NPE am: 1a0f1591de
Change-Id: Iff2bc970a78fc37f2b7721dbd651983dcf692b52
2020-04-28 15:57:27 +00:00
Taesu Lee 1a0f1591de Fix NPE
Check whether SMS delivery report preference is available first because
it could be removed if carriers don't support it.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I9e0049dd61713f7a9638fb19a37aaa261f35d768
2020-04-28 17:28:42 +09:00
Taesu Lee 948781c1ca Handle delivered messages as completed messages am: 7ccb748e61 am: cbcb1628e5 am: 3548c16d15
Change-Id: Iee9c4c2d5f59e755c319e14e19ff57a7f0312dd1
2020-04-27 18:46:02 +00:00
Taesu Lee 3548c16d15 Handle delivered messages as completed messages am: 7ccb748e61 am: cbcb1628e5
Change-Id: I81749b4559f16731a009772cb52bc83e63056d80
2020-04-27 18:33:10 +00:00
Taesu Lee cbcb1628e5 Handle delivered messages as completed messages am: 7ccb748e61
Change-Id: I202ce5f8a2a72f763a56c98708045c10550a8d73
2020-04-27 18:21:48 +00:00
Taesu Lee 7ccb748e61 Handle delivered messages as completed messages
Delivered messages could be forwarded and sent time can be shown on
MessageDetailsDialog.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I6e24bdfe6a037ab588914327dbd8abf3f30512ea
2020-04-24 10:22:39 +09:00
Xin Li c95b779f7a [automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 85eaa3e1ec -s ours am: 67be3bbf79
Change-Id: I26441f37fa59432f457f7b7baa41985fbc3080f5
2020-04-10 03:39:14 +00:00
Xin Li 67be3bbf79 [automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 85eaa3e1ec -s ours
am skip reason: subject contains skip directive

Change-Id: I90519048d9c855d8828ac647544d2653d345cbf6
2020-04-10 03:06:10 +00:00
Xin Li 85eaa3e1ec DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master
Bug: 151763422
Change-Id: Ic576a0fc228b600ee5865f70ec431c234d331786
2020-04-09 17:51:16 -07:00
Taesu Lee 2a8c11cecc Dismiss SnackBar when detached am: aa23161c03 am: 5c67dbb0d2 am: 57e6f108c7
Change-Id: I3ce6cf06f3bff5ef07bd49df8a16ed059b60315e
2020-04-02 21:59:09 +00:00
Taesu Lee 2ead48c6da Dismiss SnackBar when detached am: aa23161c03 am: 5c67dbb0d2
Change-Id: I92ebff9808c8df5625a3e542d0cae6e28a9a9c80
2020-04-02 21:37:41 +00:00
Taesu Lee 57e6f108c7 Dismiss SnackBar when detached am: aa23161c03 am: 5c67dbb0d2
Change-Id: Ib551d5788a2294374b892e8ad88448ba420b8aa7
2020-04-02 21:36:48 +00:00
Taesu Lee 5c67dbb0d2 Dismiss SnackBar when detached am: aa23161c03
Change-Id: Ib76ae11b7456549bfcb64710486da59bd56c2b34
2020-04-02 21:17:52 +00:00
Taesu Lee aa23161c03 Dismiss SnackBar when detached
SnackBarManager state is not cleared when SnackBar is detached from a
window without dismiss(). After then it is remained as dismissing state
forever.

Test: 1) Long-press a conversation and click archive action.
      2) Press back key before the snackbar is dismissed.
      3) Repeat 1) and check the snackbar is shown or not.

Change-Id: Icf2cdcd30aea42685db68e5ac36436a34c9c94ae
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-04-01 09:58:13 +09:00
Treehugger Robot b1c0d7095a Merge "Add an exported flag in manifest" am: 90c3d807c8 am: 294fec5331 am: 3ff50dfe96
Change-Id: I4f2529be500bb2e52e95caf18f8ef6fcfc3be6b0
2020-03-31 21:51:39 +00:00
Treehugger Robot 3ff50dfe96 Merge "Add an exported flag in manifest" am: 90c3d807c8 am: 294fec5331
Change-Id: Ib8fb3445ced97a972e747c6af0c26c238523df51
2020-03-31 21:36:26 +00:00
Treehugger Robot 52c52239dc Merge "Add an exported flag in manifest" am: 90c3d807c8 am: 294fec5331
Change-Id: I47db37639b7a6fd86142555229055c066564a35a
2020-03-31 21:36:22 +00:00
Treehugger Robot 294fec5331 Merge "Add an exported flag in manifest" am: 90c3d807c8
Change-Id: I68762c9e73231b6d1d85ee95ff939cfc4cd5591f
2020-03-31 21:24:59 +00:00
Treehugger Robot 90c3d807c8 Merge "Add an exported flag in manifest" 2020-03-31 21:09:08 +00:00