This suggested change is automatically generated based on group
memberships and affiliations.
Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy. We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain. It can always be
reverted if needed.
If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.
See the owner's recent review activity for context:
https://android-review.googlesource.com/q/rtenneti@google.com
To report an issue, file a bug in the Infra>Codereview component.
Change-Id: I4b84a77bf8a7bd01b8d58315021ea2249a6f539e
* We don't have strings.xml in the translation pipe yet so move it to
our own strings instead
* Add an explainer comment as well
Change-Id: I392837e194c7c5d5b4b44d5cbba2ef2f521857ed
This updates the corresponding Android.bp file to keep the runtime invisible annotations, meaning this should be a no-op.
When RELEASE_R8_ONLY_RUNTIME_VISIBLE_ANNOTATIONS is enabled, keep_runtime_invisible_annotations will become a no-op, which should lead to all runtime invisible annotations being stripped from this build.
Bug: 387958004
Change-Id: Ib0090cd30d44630a1b0a1d1f0605edb7fef8c5cf
Test: existing
R8 implicitly keeps the default constructor when no member rules are specified. Future versions of R8 will require apps to explicitly keep the default constructors that are required for the build to work.
This conservatively changes all keep rules that currently keep the default constructor to explicitly keep the default constructor.
Future work will attempt to tighten up the rules that do not require the default constructor to be kept.
Bug: 373579455
Test: existing
Change-Id: I46dc4b01c0ee38a7033d8f16419dac00fe414fb1
Since these have no effect on sdk 33 and up and everything works without
them we can get rid of those
Change-Id: I0482d8b8772dc2c64bb1930fbc6ba4852f4b4c61
On light background they stand out lighter, but on dark they just blend
in - we can reuse the attachment background to fix that!
Change-Id: I0e0f09d0cd305ce1bc8aa07c3a20b79993d40e60
* With dark theme, they suddenly don't stand out from the background
anymore
* Give them more rounding but not as much as the chat bubbles
Change-Id: I32c1036bda348e0c58e1cb37edbe9c7fc72309e7
* We don't need two settings basically doing the same
* Handling the change needs to happen via RoleIntent, not
ACTION_CHANGE_DEFAULT
* Our own name sometimes can't be retrieved from package manager (?) -
just use it from strings
Change-Id: I28abc52329f00b33a316533f12a54a517cba3514
The view doesn't have a "no items available" element and it doesn't
make sense to have one since the menu item is only visible once a contact
is blocked - so after removing the last blocked contact, simply return
back to the conversation list
Change-Id: I3372e26361f6919502cac6fd27ae849d559a4c05
* NotificationBuilder.addPerson(String) -> .addPerson(Person)
* Wearableextenter.addPage deprecated without replacement
* Html.fromHtml(String) -> .fromHtml(String, int)
* Handlers need Loopers
* Resource-IDs are not final by default (if-else instead of switch-case)
* call super.onFinishInflate() in override of onFinishInflate()
* Configuration.locale -> configuration.getLocales().get(0)
* SimpleDateFormat needs localization as well
* AudioAttributes instead of setAudioStreamType()
* isDataEnabled() is a public method, no need for reflection anymore
Change-Id: Icd830768b86edca3e0b44f1edc6c57facc9f731a
No unnecessary boxing, enhanced for loops, redundant checks and throws,
imports (removal, reordering), possible void returns
Change-Id: I7a8e1b2007e3b0906e01b41785c518d02c2f3fab
Instead of handling showing and picking the media ourselves,
use existing AcitivityResultContracts to pick images, videos
or contacts
Change-Id: I20079ad94882cc6bbfeae8d57ca0e4aa30612c01
When suspending and resuming the app, somehow the loader returns
immediately after onResume() with onLoadFinished() but somehow has no
data left (data.moveToNext() returns false) which makes the conversation
close immediately.
Restarting the loader has the desired result: We can leave the app
temporarily and come back to the same conversation again
This also fixes adding a vcard attachment (since that temporarily
leaves the app)
Change-Id: Id52e55563a11474fa776323477aa900ca4be0bbe
Treehugger Robot
Owner Cleanup Bot
Adrian Roos
LineageOS Infra
Android Build Coastguard Worker
Christoffer Adamsen
Michael W
LuK1337
Pranav Vashi