Commit Graph
1124 Commits
Author SHA1 Message Date
Taesu Lee dcfe928ff3 Fix creating ConnectivityUtil to work on any platform
After this CL, ConnectivityUtil for default subId is used again on pre
N because TelephonyManager has createForSubscriptionId() for a specific
subId from N.
Nevertheless, listen() uses the default subId on PhoneStateListener
instead of the subId on the manager still even N. On O and beyond,
ConnectivityUtil works correctly on multi-sim devices.

Revert "Fix missing computeIfAbsent() method in L_MR1 and M"

This reverts commit f0ccb76d8d.

Reason for revert: Manage ConnectivityUtil instances for subIds at least
                   on N instead.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I2f08928a6798a2ce275c5c75569ad379999d274c
2020-06-18 19:24:27 +09:00
Treehugger Robot a110636d6f Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f am: db44cbe6db am: bac9c313a7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: Ic1d6d6c1bcdb12356d6a0bb1dbca598c80a84cee
2020-06-17 17:21:15 +00:00
Treehugger Robot bac9c313a7 Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f am: db44cbe6db
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I88ec3dce9df8ebcdae903a43bfd2b8f49059ceb7
2020-06-17 17:12:06 +00:00
Treehugger Robot db44cbe6db Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13 am: 69cd91a75f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I6fade445937470598e0b09f1ae73e8e535530684
2020-06-17 16:53:08 +00:00
Treehugger Robot 69cd91a75f Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c am: feaad2df13
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: Iaccb9a0bfe078bb3712c875e30877bd2e0bdf1d2
2020-06-17 16:35:40 +00:00
Treehugger Robot feaad2df13 Merge "Fix missing computeIfAbsent() method in L_MR1 and M" am: db1ebc265c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1341554

Change-Id: I4bdfca1d8b537b3940eec4ecf1a166b78589b2db
2020-06-17 16:22:59 +00:00
Treehugger Robot db1ebc265c Merge "Fix missing computeIfAbsent() method in L_MR1 and M" 2020-06-17 16:15:32 +00:00
Taesu Lee f0ccb76d8d Fix missing computeIfAbsent() method in L_MR1 and M
Replace ConcurrentHashMap#computeIfAbsent() with containsKey() and put()
since computeIfAbsent() is added in API level 24.

Bug: 158846265
Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I3c43f0d7b1f289f0442c9359de4f099217244387
2020-06-17 19:03:26 +09:00
Taesu Lee 9f2b2181a1 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 am: 3aae6cf088 am: cfb6bd2b00
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Iacc4eb93e2e8fa12a8f96b94efedcefc5d9b7d3f
2020-06-16 17:13:31 +00:00
Taesu Lee cfb6bd2b00 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83 am: 3aae6cf088
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I3b694db3a215a3bed07620a4340f2652da353a47
2020-06-16 17:01:24 +00:00
Taesu Lee 3aae6cf088 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77 am: 742b382d83
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I42852de2576cff4a5582e5b05623cbf22716a9dc
2020-06-16 16:52:42 +00:00
Taesu Lee 742b382d83 Remove unnecessary methods from MmsUtils am: c9e85fd21a am: b9dd11dd77
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: Ied8b839de8e07d04c89be7c24aaf8ea387a663d1
2020-06-16 16:45:35 +00:00
Taesu Lee b9dd11dd77 Remove unnecessary methods from MmsUtils am: c9e85fd21a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1339795

Change-Id: I6359187593ac39b7bbd1628cab743586515f72e8
2020-06-16 16:23:53 +00:00
Taesu Lee c9e85fd21a Remove unnecessary methods from MmsUtils
Same methods in PhoneUtils are used everywhere instead.

Test: Build

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Ia17c1f17511c53a9235af462fa0809146726e89f
2020-06-16 11:00:42 +09:00
Taesu Lee 5adcd1bb5c Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 am: d851c2f7f0 am: f800178df7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I54b8f73f65294d75ba73f0bc710a7a252a1b4925
2020-06-11 19:53:07 +00:00
Taesu Lee f800178df7 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64 am: d851c2f7f0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I420e82330ac5582d165a4353d1e5b517ff7dca55
2020-06-11 19:41:14 +00:00
Taesu Lee d851c2f7f0 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8 am: c3e125df64
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Ie80fb55d3080d7f7f1f4c4dcb49aef84d09e2ee8
2020-06-11 19:29:09 +00:00
Taesu Lee c3e125df64 Allow call to phone numbers or voice mail numbers only am: 8b347325fa am: d067695cd8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: I4310dfdbf854572427d43d87a4c31702a36a1598
2020-06-11 19:16:35 +00:00
Taesu Lee d067695cd8 Allow call to phone numbers or voice mail numbers only am: 8b347325fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1331094

Change-Id: Iaa1761772b4e7991e009fce48e692a99ebe09150
2020-06-11 19:05:57 +00:00
Taesu Lee 8b347325fa Allow call to phone numbers or voice mail numbers only
It allows to call to well-formatted phone numbers or carrier specific
phone numbers starting with star sign such as *20 so that user can make
a call directly in a conversation for voice mail SMSs.

Revert "Check whether dialable only"

This reverts commit dbc43316cf.

Reason for revert: a call icon is disappeared for well-formatted phone
                   number with parentheses, dash and etc.

Test: Check the call icon in conversations for phone numbers and voice
      mail numbers.

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I1b279f8a5372b00a5a0c572f9969731f1e633389
2020-06-11 18:56:04 +09:00
Taesu Lee b578b890f7 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 am: 8a2358c4d5 am: 4209131fcc
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I8cdd684107f2d7fdc4e5be4b3ff1f3d7a78e0ad2
2020-06-08 18:18:56 +00:00
Taesu Lee 4209131fcc Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413 am: 8a2358c4d5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I745a7b56e0acb9fcb9a1f68dd977253dc3e62f7a
2020-06-08 18:01:21 +00:00
Taesu Lee 8a2358c4d5 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817 am: 2f60034413
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: I55dfb1611ea32b9318cae568a75f89b4ba77635d
2020-06-08 17:40:30 +00:00
Xin Li 3b5339efa1 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours am: 8f571212fa -s ours am: 8cb54ae1f1 -s ours am: 13a6b68aa8 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: If6d8cfa5a3329f2c110dcdc17cdc299d0c756656
2020-06-08 17:25:13 +00:00
Taesu Lee 2f60034413 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b am: 638c7a6817
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: Idd83c8097c70305e74bf86bf0b61df48e3115fd3
2020-06-08 17:25:09 +00:00
Taesu Lee 638c7a6817 Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always am: f3ea99181b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1325631

Change-Id: If82c2db8dc767a806360c91c55a056cddd2f06a9
2020-06-08 17:08:29 +00:00
Xin Li 13a6b68aa8 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours am: 8f571212fa -s ours am: 8cb54ae1f1 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I0bb8e5c145c4cac7fc72384bec31df618cd2622e
2020-06-08 16:42:09 +00:00
Xin Li 8cb54ae1f1 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours am: 8f571212fa -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I03cc090b70a60c424fe148aa3d64e3e30b345f78
2020-06-08 16:29:26 +00:00
Xin Li 8f571212fa [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours am: fffdde5087 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I7119b174b8fa106506e689315e0ccbc71551f266
2020-06-08 16:08:08 +00:00
Xin Li fffdde5087 [automerger skipped] Merge "Merge QQ3A.200605.002 into master" am: c66d3e6e32 -s ours
am skip reason: Change-Id Ie293c1c84489e4a1f20972bc056f6d2af67b79b4 with SHA-1 4e646c4948 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1323634

Change-Id: I1c87c70a6e4df7803ca0b8e310c7221fe35b1fbc
2020-06-08 15:56:53 +00:00
Taesu Lee f3ea99181b Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES always
Check CONFIG_SEND_MULTIPART_SMS_AS_SEPARATE_MESSAGES directly for each
sending messages always so that the correct config can be used for each
SIM cards in multi-sim devices.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iff80d093f43014ff2fe97caf6929aefe43911192
2020-06-08 16:12:02 +09:00
Xin Li c66d3e6e32 Merge "Merge QQ3A.200605.002 into master" 2020-06-06 01:41:24 +00:00
Taesu Lee 3ec105995f Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a am: f682a11332 am: cf18b8fd96
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I2e7a2d0b9d226b901ab31d16348493b3a55eb4e5
2020-06-05 18:28:11 +00:00
Taesu Lee cf18b8fd96 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a am: f682a11332
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I4c44fb2747710b902c45fad2ae293a1660d4ad4c
2020-06-05 18:09:30 +00:00
Taesu Lee f682a11332 Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0 am: 1fd2c4656a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: I5a8f884cce556db540b98523e5aba69e8b6cbae1
2020-06-05 17:57:44 +00:00
Taesu Lee 1fd2c4656a Fix ConcurrentModificationException am: 845aa217fc am: 93c591bdb0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia4b4c5dbe19435fc34f09bafebb0641934eec389
2020-06-05 17:45:24 +00:00
Taesu Lee 93c591bdb0 Fix ConcurrentModificationException am: 845aa217fc
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1324972

Change-Id: Ia9e1ac9906beace9db944fcbfcf7235a6c0f29ac
2020-06-05 17:31:20 +00:00
Taesu Lee 845aa217fc Fix ConcurrentModificationException
ConcurrentModificationException could be happened during iterating if
parts are added newly.

Test: Select several images on Gallery app and attach them to a message
via Sharing

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Idb96239ef2c05a08fc0727797b97739aa89f12a4
2020-06-05 14:46:51 +09:00
Xin Li 0580b4ade0 Merge QQ3A.200605.002 into master
Bug: 158095402
Merged-In: Ie293c1c84489e4a1f20972bc056f6d2af67b79b4
Change-Id: If9e62cf4c65cd4d4e029989f23b136c8f5efc7ae
2020-06-03 10:45:08 -07:00
Taesu Lee f946d02731 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 am: 5729626c46 am: 8904e4eb2e
Change-Id: I23da91f69d0b8c1ba1234d2a9d821b4267a0a1f9
2020-05-28 21:38:42 +00:00
Taesu Lee 8904e4eb2e Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573 am: 5729626c46
Change-Id: I556a102be2007103462a588f448fdab6375b8e5f
2020-05-28 21:27:33 +00:00
Taesu Lee 5729626c46 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948 am: 1efb769573
Change-Id: I3081b98fcb924bf4e92571fcc02662fdc2d74716
2020-05-28 21:14:48 +00:00
Taesu Lee 1efb769573 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742 am: 4e646c4948
Change-Id: Ibf098b5ea21f8277a142dde46793a7b9085f624c
2020-05-28 20:58:51 +00:00
Taesu Lee 4e646c4948 Parse recipients from RESPOND_VIA_MESSAGE correctly am: fcf6699742
Change-Id: Ie293c1c84489e4a1f20972bc056f6d2af67b79b4
2020-05-28 20:42:10 +00:00
Taesu Lee fcf6699742 Parse recipients from RESPOND_VIA_MESSAGE correctly
UriUtil#parseRecipientsFromSmsMmsUri() will returns a comma-separated
recipients for common use so that InsertNewMessageAction#createMessage()
can create or get a conversation correctly for RESPOND_VIA_MESSAGE.
In addition, mms/mmsto schemes are added. And it includes small cleanup
intent-filters for LaunchConversationActivity.

Test: adb shell am startservice
-a android.intent.action.RESPOND_VIA_MESSAGE -d "sms:12345678,87654321"
-e android.intent.extra.TEXT "Text"

Change-Id: I291dc765a46846982d059016d44f90873c687867
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
2020-05-28 16:43:29 +09:00
Treehugger Robot c5e825ed39 Merge "Disallow making a call to emergency numbers" am: ab856cb957 am: 6e1c1395cb am: d7098efcd1 am: 7a7734c16d am: 7b39fd25c8
Change-Id: Id1d9e70894ac21164d8f08688f9f047a985a9737
2020-05-25 22:03:51 +00:00
Treehugger Robot 5bde52eeeb Merge "Auto re-sending MMS for all the transient failures" am: 0e0bf43d46 am: c38bc2ec1b am: e15fdc0502 am: a4e196219c am: e94887e20e
Change-Id: Id355a4f168b8d682603b0fa8b301d2fd4d08eda7
2020-05-25 22:03:43 +00:00
Treehugger Robot d2c933cb75 Merge "Remove dead code" am: 6287290cea am: 653f908e22 am: 13d6b8a605 am: 7543ded553 am: 91a86f1624
Change-Id: I4a32f700ffbe2843a67b288dd58442eed321b307
2020-05-25 22:03:36 +00:00
Taesu Lee 6aff72ba38 Check whether dialable only am: dbc43316cf am: 45741a4489 am: f1f488257c am: 395876eb17 am: be4f0807b6
Change-Id: Id3d820d0ef08706ff40ec8343a655bc5fa2705a5
2020-05-25 22:03:22 +00:00
Treehugger Robot 7b39fd25c8 Merge "Disallow making a call to emergency numbers" am: ab856cb957 am: 6e1c1395cb am: d7098efcd1 am: 7a7734c16d
Change-Id: Ida066c7282aec89bbffc89d0c36be93a69d3e4e6
2020-05-25 21:51:59 +00:00