Commit Graph

23 Commits

Author SHA1 Message Date
Xin Li
8a3204f485 Revert "Remove abandoned implementation."
Revert submission 3242160-remove-messaging-package

Reason for revert: Droidmonitor created revert due to b/364617310, b/364626927, b/364617560

Reverted changes: /q/submissionid:3241481-remove-messaging-package

This reverts commit 93b5e63726.

Change-Id: I182cbf1758988d9a4950d39354266a5fb3aaabce
2024-09-04 16:17:30 -07:00
Elliott Hughes
93b5e63726 Remove abandoned implementation.
To prevent accidental ressurection via manifest errors.

Change-Id: I269dc248c2cb5e4bfdcb38334962070f1aba339e
2024-08-26 14:55:13 +00:00
Yuntao Xu
e60c364968 Convert jni/Android.mk to Android.bp
Convert the Make file to a Soong one

Bug: 186641883
Test: compared the results built by Make and Soong
Test: TreeHugger
Change-Id: I81f3acffc8b7157cf3d8a5edfce25ecdbf9ca742
2021-05-06 18:48:43 -07:00
Bob Badour
9241539342 [LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Messaging
Added SPDX-license-identifier-Apache-2.0 to:
  jni/Android.mk

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: Iea41c5bbed690ac52f3ffa7c3b1ef40d62766af4
2021-02-12 17:53:53 -08:00
Raman Tenneti
4b52654e98 AOSP/Messaging - Update language to comply with Android's inclusive language guidance.
See https://source.android.com/setup/contribute/respectful-code for reference

BUG=161896447

Test: make and make messagingtests
Change-Id: I01c520f1d5e9eab8dbb25b08d133ae34bd301093
2020-07-29 16:43:46 -07:00
Po-Chien Hsueh
003eb4915a Move libgiftranscode.so to /product
libgiftranscode.so is a jni lib for Messaging app, which is usually
overridden by proprietary apps on shipping devices. We have moved
Messaging to /product. Now this CL move libgiftranscode.so too.

Bug: 138282284
Test: Open gif files with Messaging on aosp_crosshatch
Change-Id: Ic104ba8ec5c2258a28c8d19151a00f6c601b5f80
2019-08-15 16:20:06 +08:00
Chih-Hung Hsieh
cd6efe25a4 Use -Werror in packages/apps/Messaging/jni
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I3d7f5b98523c9fee08f2d1c29178ae050923617c
2017-11-01 15:56:01 -07:00
Tom Taylor
8bace8dbea 32764144 Security Vulnerability - heap buffer overflow in libgiftranscode.so in colorMap->Colors[colorIndex] am: 6f763fef7a am: 9f00add2fb am: 71d4913462 am: 82fa311e9a am: cc649e4e1e am: 657379f51c am: fb324f89bf am: eece1bd759
am: 8495e582a1

Change-Id: I92091dcb75ea3289cb875d27bc8fa28c3028c33b
2017-01-17 20:02:06 +00:00
Tom Taylor
cc649e4e1e 32764144 Security Vulnerability - heap buffer overflow in libgiftranscode.so in colorMap->Colors[colorIndex] am: 6f763fef7a am: 9f00add2fb am: 71d4913462
am: 82fa311e9a

Change-Id: Ifd7c99312f526e379268f5f12a5ff61d95a90996
2017-01-17 19:51:36 +00:00
Tom Taylor
6f763fef7a 32764144 Security Vulnerability - heap buffer overflow in libgiftranscode.so
in colorMap->Colors[colorIndex]

* No range checking was done on a color index. Add range
checking and bail if the color index is out of range.

Test: tested sending a large gif that would invoke the GifTranscoder library
to make the gif smaller.

Bug: 32764144
Change-Id: I44f36274ec333ae1960fa8fc96b2dbde35fbaa66
2017-01-13 14:47:35 -08:00
Tom Taylor
2686c894a4 33388925 Mismatched new vs delete in framesequence library am: 837474a376 am: b44b56b779 am: cefccea7b4 am: c708e8fb35 am: 2917015529 am: 508f541438 am: 728c4943e9
am: 0d9e6a3cf5

Change-Id: I39f21154f9c40a4d4f2da0467ad46170a43502e6
2017-01-06 18:07:39 +00:00
Tom Taylor
2917015529 33388925 Mismatched new vs delete in framesequence library am: 837474a376 am: b44b56b779 am: cefccea7b4
am: c708e8fb35

Change-Id: Iac2d9f2a4f11f4e0ec70c9aa9aeb8b105729ba7b
2017-01-06 17:51:59 +00:00
Tom Taylor
837474a376 33388925 Mismatched new vs delete in framesequence library
* The array allocations neglected to include [] so delete, instead
of delete [] would get called.

* Test
Manual
- tested sending a large gif that would invoke the GifTranscoder library
to make the gif smaller.

Bug: 33388925
Change-Id: I1e200e470d66ae615ffe9340ff9c049eaa73f63c
2017-01-04 09:42:37 -08:00
Tom Taylor
88b877fa20 32322450 Security Vulnerability - heap buffer overflow in libgiftranscode.so am: bcc1f62715 am: 5311a02e27 am: 954e81ed44 am: e215495b3b am: a044afd70d am: a1562e5ab6 am: d65f900883
am: 8307b0a020

Change-Id: Ia5a7611f20f4d1dd5274df69c13939a1a7905f55
2016-12-05 23:17:49 +00:00
Tom Taylor
a044afd70d 32322450 Security Vulnerability - heap buffer overflow in libgiftranscode.so am: bcc1f62715 am: 5311a02e27 am: 954e81ed44
am: e215495b3b

Change-Id: I41014416971669f09f0d43b1a548dc56ba570e4e
2016-12-05 23:03:11 +00:00
Tom Taylor
bcc1f62715 32322450 Security Vulnerability - heap buffer overflow in libgiftranscode.so
* No range checking was done on the background color index. Add range
checking and bail if the color index is out of range.

* Test
Manual
- tested sending the gif attached in the bug.
- tested sending a 3.5mb gif to verify the gif transcoding was taking place.
- tested on arm64, arm, and x86 devices.

Change-Id: Id16ddccf05c8472ddebc1284b2a928dafd1be551
Fixes: 32322450
2016-12-01 12:20:44 -08:00
Chih-Hung Hsieh
418442d5b6 Fix misc-macro-parentheses warnings.
Bug: 28705665
Change-Id: Idc06e53ca8e25c44de63e7b2f4c465da7f4df65b
2016-05-12 10:20:09 -07:00
Dan Albert
fc922a1f53 Match the minimum version in the manifest.
Change-Id: Iab7d34552df5cf3830ec03c36872879b9ba28d7e
2016-03-22 14:20:17 -07:00
Dan Albert
374af0d0d0 Stop targeting Froyo.
Froyo isn't supported any more.

Change-Id: I0008ad0273b2aa31ca523fdedd64437bf76c5cbe
2016-03-11 11:57:05 -08:00
Matt Sarett
b0ef77450d Fix build breakage caused by updating giflib
Change-Id: I085379470620ec4db13f8baf7a9eb069747270b7
2015-08-24 11:35:24 -04:00
Mike Dodd
d3b009ae55 Initial checkin of AOSP Messaging app.
b/23110861

Change-Id: I11db999bd10656801e618f78ab2b2ef74136fff1
2015-08-12 12:47:26 -07:00
Mike Dodd
ef8c7abbcf Revert "Initial checkin of AOSP Messaging app."
This reverts commit 461a34b466.

Change-Id: Iac4ca77eeaa94989e91dead49a7959c905bd3078
2015-08-12 18:48:39 +00:00
Mike Dodd
461a34b466 Initial checkin of AOSP Messaging app.
b/23110861

Change-Id: I9aa980d7569247d6b2ca78f5dcb4502e1eaadb8a
2015-08-12 08:58:28 -07:00