Messaging: Language cleanup

No unnecessary boxing, enhanced for loops, redundant checks and throws,
imports (removal, reordering), possible void returns

Change-Id: I7a8e1b2007e3b0906e01b41785c518d02c2f3fab

src/com/android/messaging/ui/mediapicker/AudioRecordView.java

@@ -238,7 +238,7 @@ public class AudioRecordView extends FrameLayout implements
     }
 
     @VisibleForTesting
-    boolean onRecordButtonTouchDown() {
+    void onRecordButtonTouchDown() {
         if (!mMediaRecorder.isRecording() && mCurrentMode == MODE_IDLE) {
             setMode(MODE_STARTING);
             playAudioStartSound(() -> {
@@ -253,9 +253,7 @@ public class AudioRecordView extends FrameLayout implements
                 }
             });
             mAudioRecordStartTimeMillis = System.currentTimeMillis();
-            return true;
         }
-        return false;
     }
 
     @VisibleForTesting

src/com/android/messaging/ui/mediapicker/CameraManager.java

@@ -38,7 +38,6 @@ import android.view.Surface;
 import android.view.WindowManager;
 
 import com.android.messaging.datamodel.data.DraftMessageData.DraftMessageSubscriptionDataProvider;
-import com.android.messaging.Factory;
 import com.android.messaging.datamodel.data.ParticipantData;
 import com.android.messaging.datamodel.media.ImageRequest;
 import com.android.messaging.sms.MmsConfig;

src/com/android/messaging/ui/mediapicker/MediaChooser.java

@@ -27,10 +27,11 @@ import android.widget.ImageButton;
 
 import androidx.appcompat.app.ActionBar;
 import androidx.fragment.app.FragmentManager;
+
 import com.android.messaging.R;
 import com.android.messaging.datamodel.binding.ImmutableBindingRef;
-import com.android.messaging.datamodel.data.MediaPickerData;
 import com.android.messaging.datamodel.data.DraftMessageData.DraftMessageSubscriptionDataProvider;
+import com.android.messaging.datamodel.data.MediaPickerData;
 import com.android.messaging.ui.BasePagerViewHolder;
 import com.android.messaging.util.Assert;
 

src/com/android/messaging/ui/mediapicker/MediaPicker.java

@@ -17,7 +17,6 @@
 
 package com.android.messaging.ui.mediapicker;
 
-import android.app.Activity;
 import android.content.Context;
 import android.os.Bundle;
 import android.os.Handler;
@@ -188,8 +187,8 @@ public class MediaPicker extends Fragment implements DraftMessageSubscriptionDat
     private boolean mAnimateOnAttach;
 
     @Override
-    public void onAttach (final Activity activity) {
-        super.onAttach(activity);
+    public void onAttach(@NonNull final Context context) {
+        super.onAttach(context);
         mIsAttached = true;
         if (mStartingMediaTypeOnAttach != MEDA_TYPE_INVALID) {
             // open() was previously called. Do the pending open now.

src/com/android/messaging/ui/mediapicker/MediaPickerPanel.java

@@ -31,7 +31,6 @@ import android.widget.LinearLayout;
 
 import com.android.messaging.R;
 import com.android.messaging.ui.PagingAwareViewPager;
-import com.android.messaging.util.Assert;
 import com.android.messaging.util.UiUtils;
 
 /**

src/com/android/messaging/ui/mediapicker/camerafocus/FocusOverlayManager.java

@@ -545,7 +545,7 @@ public class FocusOverlayManager {
     }
 
     public static boolean isSupported(String value, List<String> supported) {
-        return supported != null && supported.indexOf(value) >= 0;
+        return supported != null && supported.contains(value);
     }
 
     public static boolean isMeteringAreaSupported(Parameters params) {