Messaging: Implement per conversation channels. Update API level to 28.
* Get rid of in-app settings for notifications, replaced by channels features * Remove all the notification plumbing and dead code Test: m, manual Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com> Signed-off-by: Joey <joey@lineageos.org> Signed-off-by: Danny Baumann <dannybaumann@web.de> Signed-off-by: Arne Coucheron <arco68@gmail.com> Signed-off-by: Lyubo <lyubodzhamov@gmail.com> Change-Id: Idb39ca32751d40b3376934775d2119dd6cc7e297
This commit is contained in:
committed by
Michael Bestas
parent
2fa1f81707
commit
4246987beb
@@ -18,18 +18,12 @@ package com.android.messaging.ui.appsettings;
|
||||
|
||||
import android.app.FragmentTransaction;
|
||||
import android.content.Intent;
|
||||
import android.content.SharedPreferences;
|
||||
import android.content.SharedPreferences.OnSharedPreferenceChangeListener;
|
||||
import android.media.Ringtone;
|
||||
import android.media.RingtoneManager;
|
||||
import android.net.Uri;
|
||||
import android.os.Bundle;
|
||||
import android.preference.Preference;
|
||||
import android.preference.PreferenceFragment;
|
||||
import android.preference.PreferenceScreen;
|
||||
import android.preference.RingtonePreference;
|
||||
import android.preference.SwitchPreference;
|
||||
import android.preference.TwoStatePreference;
|
||||
import android.provider.Settings;
|
||||
import androidx.core.app.NavUtils;
|
||||
import android.text.TextUtils;
|
||||
@@ -85,14 +79,10 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
return super.onOptionsItemSelected(item);
|
||||
}
|
||||
|
||||
public static class ApplicationSettingsFragment extends PreferenceFragment implements
|
||||
OnSharedPreferenceChangeListener {
|
||||
public static class ApplicationSettingsFragment extends PreferenceFragment {
|
||||
|
||||
private String mNotificationsEnabledPreferenceKey;
|
||||
private TwoStatePreference mNotificationsEnabledPreference;
|
||||
private String mRingtonePreferenceKey;
|
||||
private RingtonePreference mRingtonePreference;
|
||||
private Preference mVibratePreference;
|
||||
private String mNotificationsPreferenceKey;
|
||||
private Preference mNotificationsPreference;
|
||||
private String mSmsDisabledPrefKey;
|
||||
private Preference mSmsDisabledPreference;
|
||||
private String mSmsEnabledPrefKey;
|
||||
@@ -112,14 +102,9 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
getPreferenceManager().setSharedPreferencesName(BuglePrefs.SHARED_PREFERENCES_NAME);
|
||||
addPreferencesFromResource(R.xml.preferences_application);
|
||||
|
||||
mNotificationsEnabledPreferenceKey =
|
||||
getString(R.string.notifications_enabled_pref_key);
|
||||
mNotificationsEnabledPreference = (TwoStatePreference) findPreference(
|
||||
mNotificationsEnabledPreferenceKey);
|
||||
mRingtonePreferenceKey = getString(R.string.notification_sound_pref_key);
|
||||
mRingtonePreference = (RingtonePreference) findPreference(mRingtonePreferenceKey);
|
||||
mVibratePreference = findPreference(
|
||||
getString(R.string.notification_vibration_pref_key));
|
||||
mNotificationsPreferenceKey =
|
||||
getString(R.string.notifications_pref_key);
|
||||
mNotificationsPreference = findPreference(mNotificationsPreferenceKey);
|
||||
mSmsDisabledPrefKey = getString(R.string.sms_disabled_pref_key);
|
||||
mSmsDisabledPreference = findPreference(mSmsDisabledPrefKey);
|
||||
mSmsEnabledPrefKey = getString(R.string.sms_enabled_pref_key);
|
||||
@@ -130,9 +115,6 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
(SwitchPreference) findPreference(mSwipeRightToDeleteConversationkey);
|
||||
mIsSmsPreferenceClicked = false;
|
||||
|
||||
final SharedPreferences prefs = getPreferenceScreen().getSharedPreferences();
|
||||
updateSoundSummary(prefs);
|
||||
|
||||
if (!DebugUtils.isDebugEnabled()) {
|
||||
final Preference debugCategory = findPreference(getString(
|
||||
R.string.debug_pref_key));
|
||||
@@ -154,8 +136,13 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean onPreferenceTreeClick (PreferenceScreen preferenceScreen,
|
||||
public boolean onPreferenceTreeClick(PreferenceScreen preferenceScreen,
|
||||
Preference preference) {
|
||||
if (preference.getKey() == mNotificationsPreferenceKey) {
|
||||
Intent intent = new Intent(Settings.ACTION_APP_NOTIFICATION_SETTINGS);
|
||||
intent.putExtra(Settings.EXTRA_APP_PACKAGE, getContext().getPackageName());
|
||||
startActivity(intent);
|
||||
}
|
||||
if (preference.getKey() == mSmsDisabledPrefKey ||
|
||||
preference.getKey() == mSmsEnabledPrefKey) {
|
||||
mIsSmsPreferenceClicked = true;
|
||||
@@ -163,35 +150,6 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
return super.onPreferenceTreeClick(preferenceScreen, preference);
|
||||
}
|
||||
|
||||
private void updateSoundSummary(final SharedPreferences sharedPreferences) {
|
||||
// The silent ringtone just returns an empty string
|
||||
String ringtoneName = mRingtonePreference.getContext().getString(
|
||||
R.string.silent_ringtone);
|
||||
|
||||
String ringtoneString = sharedPreferences.getString(mRingtonePreferenceKey, null);
|
||||
|
||||
// Bootstrap the default setting in the preferences so that we have a valid selection
|
||||
// in the dialog the first time that the user opens it.
|
||||
if (ringtoneString == null) {
|
||||
ringtoneString = Settings.System.DEFAULT_NOTIFICATION_URI.toString();
|
||||
final SharedPreferences.Editor editor = sharedPreferences.edit();
|
||||
editor.putString(mRingtonePreferenceKey, ringtoneString);
|
||||
editor.apply();
|
||||
}
|
||||
|
||||
if (!TextUtils.isEmpty(ringtoneString)) {
|
||||
final Uri ringtoneUri = Uri.parse(ringtoneString);
|
||||
final Ringtone tone = RingtoneManager.getRingtone(mRingtonePreference.getContext(),
|
||||
ringtoneUri);
|
||||
|
||||
if (tone != null) {
|
||||
ringtoneName = tone.getTitle(mRingtonePreference.getContext());
|
||||
}
|
||||
}
|
||||
|
||||
mRingtonePreference.setSummary(ringtoneName);
|
||||
}
|
||||
|
||||
private void updateSmsEnabledPreferences() {
|
||||
if (!OsUtil.isAtLeastKLP()) {
|
||||
getPreferenceScreen().removePreference(mSmsDisabledPreference);
|
||||
@@ -222,48 +180,14 @@ public class ApplicationSettingsActivity extends BugleActionBarActivity {
|
||||
getPreferenceScreen().removePreference(mSmsEnabledPreference);
|
||||
mSmsDisabledPreference.setSummary(defaultSmsAppLabel);
|
||||
}
|
||||
updateNotificationsPreferences();
|
||||
}
|
||||
mIsSmsPreferenceClicked = false;
|
||||
}
|
||||
|
||||
private void updateNotificationsPreferences() {
|
||||
final boolean canNotify = !OsUtil.isAtLeastKLP()
|
||||
|| PhoneUtils.getDefault().isDefaultSmsApp();
|
||||
mNotificationsEnabledPreference.setEnabled(canNotify);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStart() {
|
||||
super.onStart();
|
||||
// We do this on start rather than on resume because the sound picker is in a
|
||||
// separate activity.
|
||||
getPreferenceScreen().getSharedPreferences()
|
||||
.registerOnSharedPreferenceChangeListener(this);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
super.onResume();
|
||||
updateSmsEnabledPreferences();
|
||||
updateNotificationsPreferences();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onSharedPreferenceChanged(final SharedPreferences sharedPreferences,
|
||||
final String key) {
|
||||
if (key.equals(mNotificationsEnabledPreferenceKey)) {
|
||||
updateNotificationsPreferences();
|
||||
} else if (key.equals(mRingtonePreferenceKey)) {
|
||||
updateSoundSummary(sharedPreferences);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStop() {
|
||||
super.onStop();
|
||||
getPreferenceScreen().getSharedPreferences()
|
||||
.unregisterOnSharedPreferenceChangeListener(this);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user