Messaging: Fix modifiers

We either have too few or too many

Change-Id: I09a9a38b859c68526fcbcdbc7862afe1d693f6c0

src/com/android/messaging/sms/ApnsXmlProcessor.java

@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2015 The Android Open Source Project
+ * Copyright (C) 2024 The LineageOS Project
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -37,11 +38,11 @@ import java.util.Map;
  */
 class ApnsXmlProcessor {
     public interface ApnHandler {
-        public void process(ContentValues apnValues);
+        void process(ContentValues apnValues);
     }
 
     public interface MmsConfigHandler {
-        public void process(String mccMnc, String key, String value, String type);
+        void process(String mccMnc, String key, String value, String type);
     }
 
     private static final String TAG = LogUtil.BUGLE_TAG;

src/com/android/messaging/sms/BugleUserAgentInfoLoader.java

@@ -33,7 +33,7 @@ import com.android.messaging.util.VersionUtil;
 public class BugleUserAgentInfoLoader implements UserAgentInfoLoader {
     private static final String DEFAULT_USER_AGENT_PREFIX = "Bugle/";
 
-    private Context mContext;
+    private final Context mContext;
     private boolean mLoaded;
 
     private String mUserAgent;

src/com/android/messaging/sms/MmsUtils.java

@@ -1779,8 +1779,8 @@ public class MmsUtils {
     }
 
     public static class SendReqResp {
-        public SendReq mSendReq;
-        public SendConf mSendConf;
+        public final SendReq mSendReq;
+        public final SendConf mSendConf;
 
         public SendReqResp(final SendReq sendReq, final SendConf sendConf) {
             mSendReq = sendReq;

src/com/android/messaging/sms/SmsSender.java

@@ -60,7 +60,7 @@ public class SmsSender {
     /*
      * A map for pending sms messages. The key is the random request UUID.
      */
-    private static ConcurrentHashMap<Uri, SendResult> sPendingMessageMap =
+    private static final ConcurrentHashMap<Uri, SendResult> sPendingMessageMap =
             new ConcurrentHashMap<Uri, SendResult>();
 
     private static final Random RANDOM = new Random();