Messaging: Fix modifiers

We either have too few or too many

Change-Id: I09a9a38b859c68526fcbcdbc7862afe1d693f6c0

src/com/android/messaging/mmslib/pdu/Base64.java

@@ -1,6 +1,7 @@
 /*
  * Copyright (C) 2007 Esmertec AG.
  * Copyright (C) 2007 The Android Open Source Project
+ * Copyright (C) 2024 The LineageOS Project
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -34,7 +35,7 @@ public class Base64 {
     static final int BASELENGTH = 255;
 
     // Create arrays to hold the base64 characters
-    private static byte[] base64Alphabet = new byte[BASELENGTH];
+    private static final byte[] base64Alphabet = new byte[BASELENGTH];
 
     // Populating the character arrays
     static {

src/com/android/messaging/mmslib/pdu/QuotedPrintable.java

@@ -1,6 +1,7 @@
 /*
  * Copyright (C) 2007 Esmertec AG.
  * Copyright (C) 2007 The Android Open Source Project
+ * Copyright (C) 2024 The LineageOS Project
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +21,7 @@ package com.android.messaging.mmslib.pdu;
 import java.io.ByteArrayOutputStream;
 
 public class QuotedPrintable {
-    private static byte ESCAPE_CHAR = '=';
+    private static final byte ESCAPE_CHAR = '=';
 
     /**
      * Decodes an array quoted-printable characters into an array of original bytes.
@@ -36,7 +37,7 @@ public class QuotedPrintable {
      * @return array of original bytes,
      *         null if quoted-printable decoding is unsuccessful.
      */
-    public static final byte[] decodeQuotedPrintable(byte[] bytes) {
+    public static byte[] decodeQuotedPrintable(byte[] bytes) {
         if (bytes == null) {
             return null;
         }

src/com/android/messaging/mmslib/util/DrmConvertSession.java

@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2012 The Android Open Source Project
+ * Copyright (C) 2024 The LineageOS Project
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,8 +30,8 @@ import java.io.RandomAccessFile;
 
 
 public class DrmConvertSession {
-    private DrmManagerClient mDrmClient;
-    private int mConvertSessionId;
+    private final DrmManagerClient mDrmClient;
+    private final int mConvertSessionId;
     private static final String TAG = "DrmConvertSession";
 
     private DrmConvertSession(DrmManagerClient drmClient, int convertSessionId) {

src/com/android/messaging/mmslib/util/PduCache.java

@@ -1,6 +1,7 @@
 /*
  * Copyright (C) 2008 Esmertec AG.
  * Copyright (C) 2008 The Android Open Source Project
+ * Copyright (C) 2024 The LineageOS Project
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -81,7 +82,7 @@ public final class PduCache extends AbstractCache<Uri, PduCacheEntry> {
         mUpdating = new HashSet<Uri>();
     }
 
-    public static final synchronized PduCache getInstance() {
+    public static synchronized PduCache getInstance() {
         if (sInstance == null) {
             if (LOCAL_LOGV) {
                 Log.v(TAG, "Constructing new PduCache instance.");