filab/message_q
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Messaging: Remove unnecessary toString() and String.valueOf() calls

Browse Source 
Change-Id: I5d5624386ba72b9e7074a7da909f78baaee73f75
This commit is contained in:
Michael W
2024-12-26 14:55:12 +01:00
parent 21cb2b6289
commit e35d385149
18 changed files with 40 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/com/android/messaging/datamodel/media/ImageRequestDescriptor.java
+5 -4
View File
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2015 The Android Open Source Project
* Copyright (C) 2024 The LineageOS Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,9 +96,9 @@ public abstract class ImageRequestDescriptor extends MediaRequestDescriptor<Imag
return new StringBuilder()
.append(desiredWidth).append(KEY_PART_DELIMITER)
.append(desiredHeight).append(KEY_PART_DELIMITER)
.append(String.valueOf(cropToCircle)).append(KEY_PART_DELIMITER)
.append(String.valueOf(circleBackgroundColor)).append(KEY_PART_DELIMITER)
.append(String.valueOf(isStatic)).toString();
.append(cropToCircle).append(KEY_PART_DELIMITER)
.append(circleBackgroundColor).append(KEY_PART_DELIMITER)
.append(isStatic).toString();
}
public boolean isStatic() {
@@ -110,4 +111,4 @@ public abstract class ImageRequestDescriptor extends MediaRequestDescriptor<Imag
// Called once source dimensions finally determined upon loading the image
public void updateSourceDimensions(final int sourceWidth, final int sourceHeight) {
}
}
}
src/com/android/messaging/datamodel/media/NetworkUriImageRequest.java
+5 -5
View File
@@ -66,11 +66,11 @@ public class NetworkUriImageRequest<D extends UriImageRequestDescriptor> extends
} catch (MalformedURLException e) {
LogUtil.e(LogUtil.BUGLE_TAG,
"MalformedUrl for image with url: "
+ mDescriptor.uri.toString(), e);
+ mDescriptor.uri, e);
} catch (IOException e) {
LogUtil.e(LogUtil.BUGLE_TAG,
"IOException trying to get inputStream for image with url: "
+ mDescriptor.uri.toString(), e);
+ mDescriptor.uri, e);
} finally {
if (connection != null) {
connection.disconnect();
@@ -98,16 +98,16 @@ public class NetworkUriImageRequest<D extends UriImageRequestDescriptor> extends
} catch (MalformedURLException e) {
LogUtil.e(LogUtil.BUGLE_TAG,
"MalformedUrl for image with url: "
+ mDescriptor.uri.toString(), e);
+ mDescriptor.uri, e);
} catch (final OutOfMemoryError e) {
LogUtil.e(LogUtil.BUGLE_TAG,
"OutOfMemoryError for image with url: "
+ mDescriptor.uri.toString(), e);
+ mDescriptor.uri, e);
Factory.get().reclaimMemory();
} catch (IOException e) {
LogUtil.e(LogUtil.BUGLE_TAG,
"IOException trying to get inputStream for image with url: "
+ mDescriptor.uri.toString(), e);
+ mDescriptor.uri, e);
} finally {
if (inputStream != null) {
inputStream.close();
src/com/android/messaging/datamodel/media/UriImageRequestDescriptor.java
+2 -1
View File
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2015 The Android Open Source Project
* Copyright (C) 2024 The LineageOS Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -72,7 +73,7 @@ public class UriImageRequestDescriptor extends ImageRequestDescriptor {
if (key != null) {
return new StringBuilder()
.append(uri).append(KEY_PART_DELIMITER)
.append(String.valueOf(allowCompression)).append(KEY_PART_DELIMITER)
.append(allowCompression).append(KEY_PART_DELIMITER)
.append(key).toString();
}
}